[v1.x] fix: disallow null (infinite) requested TTL#1339
Open
LucaButBoring wants to merge 2 commits intomodelcontextprotocol:v1.xfrom
Open
[v1.x] fix: disallow null (infinite) requested TTL#1339LucaButBoring wants to merge 2 commits intomodelcontextprotocol:v1.xfrom
LucaButBoring wants to merge 2 commits intomodelcontextprotocol:v1.xfrom
Conversation
The specification only allows the server to return a null TTL, it doesn't allow the client to request that. This is intentional, as it forces clients to make a choice betwen a specific TTL or not caring what the TTL is, rather than defaulting to keeping tasks forever all the time. Allowing the requested value to be null was an implementation oversight that diverged from the spec.
|
commit: |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification only allows the server to return a null TTL, it doesn't allow the client to request that. This is intentional, as it forces clients to make a choice betwen a specific TTL or not caring what the TTL is, rather than defaulting to keeping tasks forever all the time.
This change removes null as a valid requested TTL. Allowing the requested value to be null was an implementation oversight that diverged from the spec.
Motivation and Context
Fixes a request shape mismatch against the specification.
How Has This Been Tested?
Updated unit tests.
Breaking Changes
Yes, if anyone was requesting a
nullTTL.Types of changes
Checklist
Additional context
Partial backport of #1315.