MCP: Icons type as per SEP-973, spec types test improvements, ImplementationSchema use IconsSchema by KKonstantinov · Pull Request #947 · modelcontextprotocol/typescript-sdk

KKonstantinov · 2025-09-17T21:08:38Z

This PR adds Icons type support for modelcontextprotocol/modelcontextprotocol#973 (PR), which exposed additional metadata for Implementations, Resources, Tools and Prompts.

Motivation and Context

This PR adds the missing Icons type and respective IconsSchema zod schema.

Further, a few improvements have been made to spec.types.test.ts:

Moved all check* methods into a Record object
Removed loading of the same file from the filesystem and then searching via a text search for check* in favour of an actual runtime check on whether the check exists in the Record object
The previous way of checking for a string in a loaded file would make the test pass even if the check* function was to be actually commented out (or if a variable with the same name exists anywhere).
Added an additional test so MISSING_SDK_TYPES will not have any value that is already having a check inside the Record

How Has This Been Tested?

Tests and type checks are passing, there are no changes to actual implementation.

Breaking Changes

No breaking changes - just adding the Icons type and test improvements.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update

Checklist

I have read the MCP Documentation
My code follows the repository's style guidelines
New and existing tests pass locally
I have added appropriate error handling
I have added or updated documentation as needed

Additional context

…onSchema use IconsSchema

src/types.ts

cliffhall · 2025-09-17T21:36:20Z

src/spec.types.test.ts

+  it.each(typesToCheck)('%s should have a compatibility test', (type) => {
+   expect(sdkTypeChecks[type as keyof typeof sdkTypeChecks]).toBeDefined();
+  });


This should be indented one level. (why don't we have prettier on this repo??? - rhetorical)

Have ran prettier manually on the file, will commit that once the .strip topic is closed above

I don't see a resolve conversation button on the strip topic, so I'll dismiss my request. If you can push your prettier changes, will review again.

This should be indented one level. (why don't we have prettier on this repo??? - rhetorical)

@cliffhall since you mentioned this... #953 😁

cliffhall · 2025-09-17T21:37:15Z

src/spec.types.test.ts

  const specTypes = extractExportedTypes(fs.readFileSync(SPEC_TYPES_FILE, 'utf-8'));
  const sdkTypes = extractExportedTypes(fs.readFileSync(SDK_TYPES_FILE, 'utf-8'));
-  const testSource = fs.readFileSync(__filename, 'utf-8');
+  const typesToCheck = specTypes.filter(type => !MISSING_SDK_TYPES.includes(type));


cliffhall

Just the prettier changes.

…onstantinov/typescript-sdk into feature/SEP-973-icons-type-spec-tests

KKonstantinov · 2025-09-29T10:18:24Z

Tests on the main branch are now failing because of the "sizes" property change in the spec.

This PR now sorts that too.

cc @ihrpr @cliffhall

cliffhall

This lines up with the spec change that was just merged.

felixweinberger · 2025-09-29T18:51:15Z

Missed this PR while reviewing this quick CI fix: #981

Introduces a small conflict as that PR already replaces

    sizes: z.optional(z.array(z.string())),

KKonstantinov · 2025-09-29T18:53:26Z

Missed this PR while reviewing this quick CI fix: #981

Introduces a small conflict as that PR already replaces
    sizes: z.optional(z.array(z.string())),

hehe! Was just merging it. Merge pushed.

ihrpr

thanks so much for working on this. left some comments on comments but otherwise looks good!

ihrpr · 2025-09-30T14:16:06Z

src/types.ts

+/**
+ * An optional list of icons for this implementation.
+ * This can be used by clients to display the implementation in a user interface.
+ * Each icon should have a `kind` property that specifies whether it is a data representation or a URL source, a `src` property that points to the icon file or data representation, and may also include a `mimeType` and `sizes` property.


Where is the kind coming from? I think it's fine not explain too much what IconSchema should look like as we have a definition right above

Updated the comment with the latest from the spec.

ihrpr · 2025-09-30T14:16:38Z

src/types.ts

+ * This can be used by clients to display the implementation in a user interface.
+ * Each icon should have a `kind` property that specifies whether it is a data representation or a URL source, a `src` property that points to the icon file or data representation, and may also include a `mimeType` and `sizes` property.
+ * The `mimeType` property should be a valid MIME type for the icon file, such as "image/png" or "image/svg+xml".
+ * The `sizes` property should be a string that specifies one or more sizes at which the icon file can be used, such as "48x48" or "any" for scalable formats like SVG.


oh, this changed to an array here

Updated with the same comments from the main spec

ihrpr · 2025-09-30T14:52:43Z

@KKonstantinov if it's not too much to ask, please can we also add this: modelcontextprotocol/modelcontextprotocol#1565 🙏

…lcontextprotocol#1565

KKonstantinov · 2025-09-30T15:59:48Z

@KKonstantinov if it's not too much to ask, please can we also add this: modelcontextprotocol/modelcontextprotocol#1565 🙏

Done!

ihrpr

Thank you!

…ntationSchema use IconsSchema (modelcontextprotocol#947)

Icons type as per SEP-973, spec types test improvements, Implementati…

4b94617

…onSchema use IconsSchema

KKonstantinov requested review from a team and felixweinberger September 17, 2025 21:08

cliffhall suggested changes Sep 17, 2025

View reviewed changes

KKonstantinov and others added 2 commits September 18, 2025 16:43

Merge branch 'main' into feature/SEP-973-icons-type-spec-tests

1fde508

prettier format, IconsSchema strip instead of passthrough

c041fa6

cliffhall self-requested a review September 18, 2025 23:15

cliffhall suggested changes Sep 18, 2025

View reviewed changes

KKonstantinov and others added 3 commits September 19, 2025 08:46

revert IconsSchema to passthrough - to be moved to strip in PR#792

fbf98f4

Merge branch 'feature/SEP-973-icons-type-spec-tests' of github.com:KK…

5e65e64

…onstantinov/typescript-sdk into feature/SEP-973-icons-type-spec-tests

Merge branch 'main' into feature/SEP-973-icons-type-spec-tests

85d79e5

felixweinberger force-pushed the main branch from 1d475bb to 0845a57 Compare September 25, 2025 14:52

felixweinberger requested review from a team and ochafik September 25, 2025 14:52

felixweinberger force-pushed the main branch from 0845a57 to c94ba4b Compare September 25, 2025 14:53

KKonstantinov and others added 2 commits September 29, 2025 13:12

Merge branch 'main' into feature/SEP-973-icons-type-spec-tests

cc91c4c

Icon schema sizes property - align with spec

4898f67

KKonstantinov mentioned this pull request Sep 29, 2025

MCP SDK: Add Prettier to Typescript SDK #976

Merged

9 tasks

update comment on sizes prop, fix simpleStreamableHttp example

f9acee2

pja-ant mentioned this pull request Sep 29, 2025

Change Icon.sizes from string to string array modelcontextprotocol/modelcontextprotocol#1531

Merged

ihrpr self-assigned this Sep 29, 2025

cliffhall approved these changes Sep 29, 2025

View reviewed changes

felixweinberger added the improves spec compliance When a change improves ability of SDK users to comply with spec definition label Sep 29, 2025

merge commit

810dda0

ihrpr requested changes Sep 30, 2025

View reviewed changes

add IconsSchema to ResourceTemplates as per modelcontextprotocol/mode…

cf82e7d

…lcontextprotocol#1565

fix comments

ef62ae0

ihrpr approved these changes Sep 30, 2025

View reviewed changes

ihrpr merged commit 856d9ec into modelcontextprotocol:main Sep 30, 2025
2 checks passed

SVLaursen pushed a commit to SVLaursen/typescript-sdk that referenced this pull request Oct 7, 2025

MCP: Icons type as per SEP-973, spec types test improvements, Impleme…

05962dc

…ntationSchema use IconsSchema (modelcontextprotocol#947)

felixweinberger mentioned this pull request Oct 30, 2025

Implement SEP-973: Expose additional metadata for Implementations, Resources, Tools and Prompts #918

Closed

felixweinberger linked an issue Nov 11, 2025 that may be closed by this pull request

Implement SEP-973: Expose additional metadata for Implementations, Resources, Tools and Prompts #918

Closed

Comments

Conversation

KKonstantinov commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

Checklist

Additional context

Uh oh!

Uh oh!

cliffhall Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cliffhall left a comment

Choose a reason for hiding this comment

Uh oh!

KKonstantinov commented Sep 29, 2025

Uh oh!

cliffhall left a comment

Choose a reason for hiding this comment

Uh oh!

felixweinberger commented Sep 29, 2025

Uh oh!

KKonstantinov commented Sep 29, 2025

Uh oh!

ihrpr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ihrpr commented Sep 30, 2025

Uh oh!

KKonstantinov commented Sep 30, 2025

Uh oh!

ihrpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KKonstantinov commented Sep 17, 2025 •

edited

Loading

cliffhall Sep 17, 2025 •

edited

Loading