PYTHON-5543 PyMongoBaseProtocol should inherit from asyncio.BaseProtocol#2528
PYTHON-5543 PyMongoBaseProtocol should inherit from asyncio.BaseProtocol#2528aclark4life merged 3 commits intomongodb:masterfrom
Conversation
- Import and use BaseProtocol instead of Protocal in PyMongoBaseProtocoal implementation. Resolves issue with instance type check in uvloop that prevents correct buffered config from being set.
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
Can you change the title of the PR to reflect the change better? Something like "PyMongoBaseProtocol should inherit from asyncio.BaseProtocol".
doc/changelog.rst
Outdated
| Version 4.15.1 is a bug fix release. | ||
|
|
||
| - Fixed a bug in ``MongoClient.network_layer`` and ``AsyncMongoClient.network_layer`` | ||
| that could cause an ``TimeoutError`` when connecting to servers. |
There was a problem hiding this comment.
We don't need to call out that the bug was in network_layer. We do need to call out that it was a bug with AsyncMongoClient, and only with uvicorn and uvloop.
There was a problem hiding this comment.
OK I'll fix, what about the difference between PYTHON-5543 and PYTHON-5544? I couldn't reproduce for PYTHON-5543 because the reproducer was incomplete. Should we assume some use of uvicorn with FastAPI?
There was a problem hiding this comment.
I closed PYTHON-5543 as a duplicate. Let me know if that's incorrect.
There was a problem hiding this comment.
uvicorn defaults to uvloop under the hood.
|
drivers-pr-bot please backport to v4.15 |
aclark4life
changed the title
Co-authored-by: Noah Stapp <noah@noahstapp.com>
…aseProtocol (mongodb#2528)" This reverts commit 3da6e85.
…aseProtocol (mongodb#2528)" This reverts commit 3da6e85.
…syncio.BaseProtocol (mongodb#2528)"" This reverts commit e9db3be.
3 participants
BaseProtocolinstead ofProtocolinPyMongoBaseProtocolimplementation added in PYTHON-5215.