Conversation
ShaneHarvey
requested changes
Sep 11, 2025
.github/workflows/codeql.yml
Outdated
Member
There was a problem hiding this comment.
Do we actually want to backport these changes? I'd say 4.15.1 should only have PYTHON-5540 and PYTHON-5543.
Member
There was a problem hiding this comment.
Thanks. Could you revert the v6 change here too?
Member
Could you update the target branch to v4.15? |
…col (#2528) Co-authored-by: Noah Stapp <noah@noahstapp.com>
9c5259e to
10de931
Compare
ShaneHarvey
reviewed
Sep 11, 2025
doc/changelog.rst
Outdated
Member
There was a problem hiding this comment.
Could you also fix the bullet point above? - Fixed a bug in has an extra space before the -, hence it renders incorrectly. The same issue is in the 4.14.1 section too.
This reverts commit 1eb824a.
NoahStapp
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.