PYTHON-5663 Fix unified test discovery#2644
Merged
blink1073 merged 2 commits intomongodb:masterfrom Dec 16, 2025
Merged
Conversation
Jibola
requested changes
Dec 12, 2025
| else: | ||
| TEST_PATH = os.path.join(Path(__file__).resolve().parent.parent, "unified-test-format") | ||
|
|
||
| TEST_PATH = get_test_path("unified-test-format") |
Contributor
There was a problem hiding this comment.
I'm thinking we can remove all the ones that put this TEST_PATH or _TEST_PATH variable still, just for consistency's sake.
Any compelling reason not to?
Member
Author
There was a problem hiding this comment.
The ones I left used the variable other places in the file, for different subdirs
Jibola
approved these changes
Dec 16, 2025
blink1073
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5663
Changes in this PR
Add a helper function to get the unified test path and ensure that there are testable file(s) when generating tests.
Test Plan
Standard Tests
Checklist
Checklist for Author
Checklist for Reviewer