PYTHON-5679 Optimize ObjectId.__str__()#2657
Merged
blink1073 merged 2 commits intomongodb:masterfrom Dec 18, 2025
Merged
Conversation
Like mongodb#2656, I spotted this function taking ~0.9% of request time in a project using mongoengine. [`bytes.hex()`](https://docs.python.org/3/library/stdtypes.html#bytes.hex) was added in Python 3.5 and does the same as `binascii.hexlify(...).decode()` but faster, so I've replaced it here. (The `binascii.hexlify()` docs also now point to `bytes.hex()` as a faster alternative.) Benchmarked again using [`richbench`](https://github.com/tonybaloney/rich-bench) with the below script. <details> <summary><code>bench_objectid_str.py</code></summary> ```python from __future__ import annotations import binascii import os class ObjectIdBefore: __slots__ = ("__id",) def __init__(self) -> None: self.__id = os.urandom(12) def __str__(self) -> str: return binascii.hexlify(self.__id).decode() class ObjectIdAfter: __slots__ = ("__id",) def __init__(self) -> None: self.__id = os.urandom(12) def __str__(self) -> str: return self.__id.hex() test_oids_before = [ObjectIdBefore() for _ in range(100)] test_oids_after = [ObjectIdAfter() for _ in range(100)] def bench_str_before(): for oid in test_oids_before: for _ in range(100_000): str(oid) def bench_str_after(): for oid in test_oids_after: for _ in range(100_000): str(oid) __benchmarks__ = [ (bench_str_before, bench_str_after, "str(ObjectId) - hex conversion"), ] ``` </details> Results show a ~1.4x speedup: ``` $ uvx -p 3.13 richbench . Benchmarks, repeat=5, number=5 ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓ ┃ Benchmark ┃ Min ┃ Max ┃ Mean ┃ Min (+) ┃ Max (+) ┃ Mean (+) ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━┩ │ str(ObjectId) - hex conversion │ 3.000 │ 3.061 │ 3.019 │ 2.169 (1.4x) │ 2.231 (1.4x) │ 2.196 (1.4x) │ └────────────────────────────────┴─────────┴─────────┴─────────┴─────────────────┴─────────────────┴─────────────────┘ ```
ObjectId.__str__()ObjectId.__str__()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Like #2656, I spotted this function taking ~0.9% of request time in a project using mongoengine.
bytes.hex()was added in Python 3.5 and does the same asbinascii.hexlify(...).decode()but faster, so I've replaced it here. (Thebinascii.hexlify()docs also now point tobytes.hex()as a faster alternative.)Test Plan
Benchmarked again using
richbenchwith the below script.bench_objectid_str.pyResults show a ~1.4x speedup:
Checklist
Checklist for Author
Checklist for Reviewer