-
Notifications
You must be signed in to change notification settings - Fork 173
Enhance prototype pollution protection #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gfx
merged 1 commit into
msgpack:main
from
zjs81:fix/complete-prototype-pollution-protection
Jan 20, 2026
+38
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,4 +19,40 @@ describe("prototype pollution", () => { | |
| }, DecodeError); | ||
| }); | ||
| }); | ||
|
|
||
| context("constructor exists as a map key", () => { | ||
| it("raises DecodeError in decoding", () => { | ||
| const o = { | ||
| foo: "bar", | ||
| }; | ||
| // override constructor as an enumerable property | ||
| Object.defineProperty(o, "constructor", { | ||
| value: new Date(0), | ||
| enumerable: true, | ||
| }); | ||
| const encoded = encode(o); | ||
|
|
||
| throws(() => { | ||
| decode(encoded); | ||
| }, DecodeError); | ||
|
Comment on lines
+35
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of just testing that it fails to decode, you should've instead tested that, even in the hostile environment where you've imagined a current security issue, the library does not trigger it. |
||
| }); | ||
| }); | ||
|
|
||
| context("prototype exists as a map key", () => { | ||
| it("raises DecodeError in decoding", () => { | ||
| const o = { | ||
| foo: "bar", | ||
| }; | ||
| // override prototype as an enumerable property | ||
| Object.defineProperty(o, "prototype", { | ||
| value: new Date(0), | ||
| enumerable: true, | ||
| }); | ||
| const encoded = encode(o); | ||
|
|
||
| throws(() => { | ||
| decode(encoded); | ||
| }, DecodeError); | ||
| }); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same thing as