adding image.flavor to values.yaml and clarifying image.tag in README configuration table#438
Open
jessebot wants to merge 3 commits intonextcloud:mainfrom
Open
adding image.flavor to values.yaml and clarifying image.tag in README configuration table#438jessebot wants to merge 3 commits intonextcloud:mainfrom
image.flavor to values.yaml and clarifying image.tag in README configuration table#438jessebot wants to merge 3 commits intonextcloud:mainfrom
Conversation
jessebot
commented
Sep 2, 2023
jessebot
commented
Sep 3, 2023
jessebot
commented
Sep 3, 2023
jessebot
commented
Sep 3, 2023
jessebot
commented
Sep 4, 2023
jessebot
force-pushed
the
clarify-flavor-tag
branch
from
513d245 to
60b293d
Compare
… configuration table with link to appVersion in Chart.yaml Signed-off-by: jessebot <jessebot@linux.com>
jessebot
force-pushed
the
clarify-flavor-tag
branch
from
60b293d to
47a3f35
Compare
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
This just updates the comments for
image.tagandimage.flavorin values.yaml and README.md to explain where the default tag comes from (appVersionin Chart.yaml) and also that you need to set the flavor to fpm if you'd like to use nginxBenefits
Gives a bit more clarity on how this chart works, which can be really helpful for new users of nextcloud and/or kubernetes/helm.
Possible drawbacks
none that jump out to me, but happy to hear feedback
Checklist
Chart.yamlaccording to semver.