Fix: Wait for the runtime-deploy 'runtime-event' before starting flows#66
Open
WS-Daniel wants to merge 1 commit intonode-red:masterfrom
Open
Fix: Wait for the runtime-deploy 'runtime-event' before starting flows#66WS-Daniel wants to merge 1 commit intonode-red:masterfrom
WS-Daniel wants to merge 1 commit intonode-red:masterfrom
Conversation
|
|
Member
|
Thanks for this. You've caught me with one foot out the door for vacation. I'll take a proper look at this on my return, but please do ping if I haven't responded in a couple weeks. |
Contributor
|
@WS-Daniel thanks for this. Could you please sign the CLA? |
Author
I am trying to move this but I am not sure I have enough strength to push a CLA Manager into the company for this small contribution. |
Author
|
Hi! Just ping @knolleary, the CLA is signed now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found some tests were failing randomly under certain conditions, but sometimes they worked.
Upon deeper analysis I found the NodeTestHelper.load() function awaits the loadFlows() promise to be fulfilled, but loadFlows() triggers setFlows in Node-RED which returns a 'configSavePromise' but within that promise, there is a start() call that is not awaited.
In order to make sure the flow is completely deployed, we need to await for the "runtime-event" event with id "runtime-deploy", before considering loadFlows() completed and proceeding to startFlows().
The "runtime-event" id === "runtime-deploy" event exists since version 0.16 of Node-RED. The helper initial version was for 0.18.2 already, thus, I do not judge important to check if Node-RED version supports this event.