Pull Request: Twitter-In node topics on input, refresh interval input#803
Open
hgill wants to merge 1 commit intonode-red:masterfrom
Open
Pull Request: Twitter-In node topics on input, refresh interval input#803hgill wants to merge 1 commit intonode-red:masterfrom
hgill wants to merge 1 commit intonode-red:masterfrom
Conversation
…er than hard-coded 2. "Sticky" followers: If new input string suggests updates in handles to follow, creates "sticky" new intervals - meaning previously followed handles are maintained, new ones added 3. Node now takes refresh time as an input value, previously hardcoded at 60s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updates on Twitter-In node:
Other info:
4. I didn't add unit test cases, as I couldn't get the unit test lib to work as expected - can do with some guidance
5. I intended to use the latest Twitter API v2 which has breaking changes, but till v1.1 is functioning, thought it's best to let it be. When Twitter announces sunsetting of v1.1, I would like to contribute to upgrading this library to support v2.
Checklist
gruntto verify the unit tests pass