Conversation
|
@aduh95 ... Just wanted to get a sense of what this PR is working towards. Want to have context for a review. This is used by workers and bun also so need to know if there are significant changes that would require attention there also |
|
The end goal would be to be able to build it as a shared lib and use it in node (in the test-shared workflow), and make node depend on this repo. The current state is that I'm able to build it as a shared lib, but static build seems broken from the looks of CI, I haven't investigated further. |
|
Sounds good to me. Can you rebase? |
|
cc @npaun |
|
What's the status here? It'd be helpful for me to have an overview what are the blockers so I can make an estimate of how long before the effort is complete |
|
I was waiting for a review from @jasnell. He's probably on a flight to US right now. |
Currently the code is maintained in two different repos (nodejs/node and nodejs/ncrypto) which are slightly diverging. This PR takes the nodejs/node version as source of truth (I copied the file over, and reverted only the changes that were behind a
#ifndefpre-compiler flag).