Skip to content

esm: update outdated FIXME comment in translators.js#61715

Open
karan-lrn wants to merge 2 commits intonodejs:mainfrom
karan-lrn:esm-update-fixme-comment
Open

esm: update outdated FIXME comment in translators.js#61715
karan-lrn wants to merge 2 commits intonodejs:mainfrom
karan-lrn:esm-update-fixme-comment

Conversation

@karan-lrn
Copy link

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Feb 7, 2026
@karan-lrn
Copy link
Author

cc @nodejs/loaders @joyeecheung

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@karan-lrn
Copy link
Author

@joyeecheung Thanks for the feedback! Updated to remove the specific quirks mention. I appreciate the pointer to the official docs.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (3ab9dd8) to head (67cc5c0).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61715      +/-   ##
==========================================
- Coverage   89.73%   89.72%   -0.01%     
==========================================
  Files         675      675              
  Lines      204502   204525      +23     
  Branches    39304    39301       -3     
==========================================
+ Hits       183502   183516      +14     
- Misses      13283    13288       +5     
- Partials     7717     7721       +4     
Files with missing lines Coverage Δ
lib/internal/modules/esm/translators.js 92.35% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 8, 2026
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants