Skip to content

meta: update scorecard egress-policy from audit to block #61738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ronitsabhaya75 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

meta: update scorecard egress-policy from audit to block #61738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Harden Runner
uses: step-security/harden-runner@e3f713f2d8f53843e71c69a996d56f51aa9adfb9 # v2.14.1
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs
egress-policy: block
Copy link
Contributor

@mateonunez mateonunez Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ronitsabhaya75, as we transition from audit to block mode, we must ensure the allowed-endpoints list is exhaustive to avoid breaking the CI pipeline

Copy link
Contributor Author

@Ronitsabhaya75 Ronitsabhaya75 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateonunez Good point! Since we've run in audit mode since November 2025, harden-runner has auto-detected the required endpoints and will allow them in block mode. Let me know if you'd prefer an explicit allowed-endpoints list for clarity.

Copy link
Contributor

@mateonunez mateonunez Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think is better to have an explicit allowed-endpoints for clarity. What do you think, @aduh95?

Copy link
Contributor Author

@Ronitsabhaya75 Ronitsabhaya75 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateonunez i think it would be better to have explicit conditions. So that we can use audit and in meantime if condition fails then we can block.


- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down