http: remove redundant keepAliveTimeoutBuffer assignment#61743
Open
efekrskl wants to merge 1 commit intonodejs:mainfrom
Open
http: remove redundant keepAliveTimeoutBuffer assignment#61743efekrskl wants to merge 1 commit intonodejs:mainfrom
efekrskl wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61743 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 675 675
Lines 204525 204519 -6
Branches 39314 39304 -10
=======================================
+ Hits 183523 183529 +6
+ Misses 13300 13293 -7
+ Partials 7702 7697 -5
🚀 New features to boost your workflow:
|
Flarna
approved these changes
Feb 8, 2026
lpinca
approved these changes
Feb 8, 2026
gurgunday
approved these changes
Feb 8, 2026
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
mcollina
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storeHTTPOptions()(see lib/_http_server.js:496) already validates and initializeskeepAliveTimeoutBuffer. This PR removes the redundant assignment so option validation and defaulting have a single source of truth.