sqlite: handle stmt invalidation#61877
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Mar 2, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61877 +/- ##
==========================================
- Coverage 91.77% 89.76% -2.01%
==========================================
Files 338 674 +336
Lines 140064 204891 +64827
Branches 22045 39381 +17336
==========================================
+ Hits 128543 183928 +55385
- Misses 11298 13239 +1941
- Partials 223 7724 +7501
🚀 New features to boost your workflow:
|
Renegade334
reviewed
Feb 19, 2026
Renegade334
approved these changes
Feb 21, 2026
Member
|
@nodejs/sqlite any other comments? |
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61877 ✔ Done loading data for nodejs/node/pull/61877 ----------------------------------- PR info ------------------------------------ Title sqlite: handle stmt invalidation (#61877) Author Guilherme Araújo <arauujogui@gmail.com> (@araujogui) Branch araujogui:sqlite-invalidate -> nodejs:main Labels c++, author ready, needs-ci, sqlite Commits 2 - sqlite: handle stmt invalidation - src: inline reset Committers 1 - Guilherme Araújo <arauujogui@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61877 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61877 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 18 Feb 2026 19:31:59 GMT ✔ Approvals: 1 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/61877#pullrequestreview-3835698239 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-03-02T13:27:42Z: https://ci.nodejs.org/job/node-test-pull-request/71520/ - Querying data for job/node-test-pull-request/71520/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 5554a288c6..ddecee7447 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - e766492a00 cli: add --max-heap-size option - ddecee7447 cli: add --max-heap-size option -------------------------------------------------------------------------------- HEAD is now at ddecee7447 cli: add --max-heap-size option ✔ Reset to origin/main - Downloading patch for 61877 From https://github.com/nodejs/node * branch refs/pull/61877/merge -> FETCH_HEAD ✔ Fetched commits as e78bf55913d5..5b2876e057e9 -------------------------------------------------------------------------------- Auto-merging src/node_sqlite.cc Auto-merging src/node_sqlite.h [main f6e4128321] sqlite: handle stmt invalidation Author: Guilherme Araújo <arauujogui@gmail.com> Date: Wed Feb 18 15:16:32 2026 -0300 3 files changed, 67 insertions(+) Auto-merging src/node_sqlite.cc Auto-merging src/node_sqlite.h [main c48b7a6393] src: inline reset Author: Guilherme Araújo <arauujogui@gmail.com> Date: Fri Feb 20 17:26:28 2026 -0300 2 files changed, 10 insertions(+), 8 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:658) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- sqlite: handle stmt invalidationhttps://github.com/nodejs/node/actions/runs/22600094138 |
Collaborator
|
Landed in 88be44d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61819