Skip to content

sqlite: handle stmt invalidation#61877

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
araujogui:sqlite-invalidate
Mar 2, 2026
Merged

sqlite: handle stmt invalidation#61877
nodejs-github-bot merged 2 commits intonodejs:mainfrom
araujogui:sqlite-invalidate

Conversation

@araujogui
Copy link
Member

Fixes #61819

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (94b1f66) to head (5b2876e).
⚠️ Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61877      +/-   ##
==========================================
- Coverage   91.77%   89.76%   -2.01%     
==========================================
  Files         338      674     +336     
  Lines      140064   204891   +64827     
  Branches    22045    39381   +17336     
==========================================
+ Hits       128543   183928   +55385     
- Misses      11298    13239    +1941     
- Partials      223     7724    +7501     
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.94% <100.00%> (ø)
src/node_sqlite.h 80.39% <ø> (ø)

... and 458 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 2, 2026
@Renegade334
Copy link
Member

@nodejs/sqlite any other comments?

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2026
@nodejs-github-bot
Copy link
Collaborator

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 2, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61877
✔  Done loading data for nodejs/node/pull/61877
----------------------------------- PR info ------------------------------------
Title      sqlite: handle stmt invalidation (#61877)
Author     Guilherme Araújo <arauujogui@gmail.com> (@araujogui)
Branch     araujogui:sqlite-invalidate -> nodejs:main
Labels     c++, author ready, needs-ci, sqlite
Commits    2
 - sqlite: handle stmt invalidation
 - src: inline reset
Committers 1
 - Guilherme Araújo <arauujogui@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61877
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61877
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 18 Feb 2026 19:31:59 GMT
   ✔  Approvals: 1
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61877#pullrequestreview-3835698239
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-03-02T13:27:42Z: https://ci.nodejs.org/job/node-test-pull-request/71520/
- Querying data for job/node-test-pull-request/71520/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   5554a288c6..ddecee7447  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - e766492a00 cli: add --max-heap-size option
 - ddecee7447 cli: add --max-heap-size option
--------------------------------------------------------------------------------
HEAD is now at ddecee7447 cli: add --max-heap-size option
   ✔  Reset to origin/main
- Downloading patch for 61877
From https://github.com/nodejs/node
 * branch                  refs/pull/61877/merge -> FETCH_HEAD
✔  Fetched commits as e78bf55913d5..5b2876e057e9
--------------------------------------------------------------------------------
Auto-merging src/node_sqlite.cc
Auto-merging src/node_sqlite.h
[main f6e4128321] sqlite: handle stmt invalidation
 Author: Guilherme Araújo <arauujogui@gmail.com>
 Date: Wed Feb 18 15:16:32 2026 -0300
 3 files changed, 67 insertions(+)
Auto-merging src/node_sqlite.cc
Auto-merging src/node_sqlite.h
[main c48b7a6393] src: inline reset
 Author: Guilherme Araújo <arauujogui@gmail.com>
 Date: Fri Feb 20 17:26:28 2026 -0300
 2 files changed, 10 insertions(+), 8 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:658) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
sqlite: handle stmt invalidation

PR-URL: #61877
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>

[detached HEAD 489753fd3f] sqlite: handle stmt invalidation
Author: Guilherme Araújo <arauujogui@gmail.com>
Date: Wed Feb 18 15:16:32 2026 -0300
3 files changed, 67 insertions(+)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: inline reset

PR-URL: #61877
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>

[detached HEAD 81ae98af3d] src: inline reset
Author: Guilherme Araújo <arauujogui@gmail.com>
Date: Fri Feb 20 17:26:28 2026 -0300
2 files changed, 10 insertions(+), 8 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/22600094138

@addaleax addaleax added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 2, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2026
@nodejs-github-bot nodejs-github-bot merged commit 88be44d into nodejs:main Mar 2, 2026
82 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 88be44d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite: statement iterator state is corrupted by coincident statement execution

4 participants