lib: fix source map url parse in dynamic imports#61990
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 3, 2026
Merged
lib: fix source map url parse in dynamic imports#61990nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
legendecas
added
lib / src
Member
Member
Author
|
I think the coverage |
cjihrig
approved these changes
Feb 26, 2026
legendecas
force-pushed
the
invalid-source-map-url
branch
from
5a5e0d6 to
91b84d6
Compare
targos
approved these changes
Feb 26, 2026
legendecas
force-pushed
the
invalid-source-map-url
branch
from
91b84d6 to
0fec8af
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61990 +/- ##
==========================================
- Coverage 89.77% 89.65% -0.12%
==========================================
Files 674 676 +2
Lines 205705 206032 +327
Branches 39449 39464 +15
==========================================
+ Hits 184670 184722 +52
- Misses 13280 13450 +170
- Partials 7755 7860 +105 🚀 New features to boost your workflow:
|
Collaborator
Collaborator
Member
Author
|
CI is green now. Would you mind taking another look? Thank you! @juanarbol @cjihrig @targos |
legendecas
added
the
author ready
cjihrig
approved these changes
Mar 3, 2026
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in afc30b7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61988