stream: optimize webstreams pipeTo further#62079
Draft
MattiasBuelens wants to merge 5 commits intonodejs:mainfrom
Draft
stream: optimize webstreams pipeTo further#62079MattiasBuelens wants to merge 5 commits intonodejs:mainfrom
pipeTo further#62079MattiasBuelens wants to merge 5 commits intonodejs:mainfrom
Conversation
jasnell
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started looking more closely at the
pipeTo()implementation, and found some low-hanging fruit to further optimize it:await writer.readyevery time, that's only needed if there is backpressure. So we check that first.writer.desiredSizeto check if there is backpressure, we can read that directly from the internal state of theWritableStreamDefaultController.readableStreamDefaultControllerCallPullIfNeededalready checksstate === 'readable' && !closeRequestedthroughreadableStreamDefaultControllerCanCloseOrEnqueue, so we don't have to repeat that check.This also fixes a few more edge cases:
writer.desiredSizeinsidepipeTo(), which is part of the publicWritableStreamDefaultWriterAPI, and step 15 of the spec explicitly forbids using the public API since it can be modified by user-land code. We now bypass this entirely usingdest[kState].backpressure.patched-global.any.jssuite.On my machine, this improves the
webstreams/pipe-to.jsbenchmark by 3% to 7%:Baseline @ 199daab
This PR @ 7b31401