stream: replace bind with arrow function for onwrite callback#62087
Open
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Open
stream: replace bind with arrow function for onwrite callback#62087thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62087 +/- ##
==========================================
- Coverage 89.65% 89.65% -0.01%
==========================================
Files 676 676
Lines 206312 206325 +13
Branches 39522 39523 +1
==========================================
+ Hits 184972 184977 +5
- Misses 13469 13472 +3
- Partials 7871 7876 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
onwrite.bind(undefined, stream)with an arrow function.Writable creation +29.92%
Duplex creation +19.91%