Skip to content

test: avoid flaky run wait in debugger restart test#62112

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-run-break
Open

test: avoid flaky run wait in debugger restart test#62112
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-run-break

Conversation

@inoway46
Copy link
Contributor

@inoway46 inoway46 commented Mar 5, 2026

Summary

Follow-up to #61773

test/parallel/test-debugger-run-after-quit-restart.js can still flake on macOS unusual-path runs around run.
stepCommand('run') expects a break message immediately, but run may return ok/prompt before the break output.
This change switches those calls to command('run') and keeps waitForInitialBreak() for the actual break sync.

failed CI logs:

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"
  • ./tools/test.py -p actions parallel/test-debugger-run-after-quit-restart
  • ./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart
  • ./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart (unusual path)

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 5, 2026
@inoway46 inoway46 marked this pull request as ready for review March 5, 2026 12:12
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (1647288) to head (52103c6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62112   +/-   ##
=======================================
  Coverage   89.64%   89.65%           
=======================================
  Files         676      676           
  Lines      206330   206330           
  Branches    39518    39517    -1     
=======================================
+ Hits       184973   184977    +4     
+ Misses      13480    13475    -5     
- Partials     7877     7878    +1     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants