fix(cicd): add -- before passing an argument#8282
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8282 +/- ##
==========================================
+ Coverage 76.55% 76.57% +0.02%
==========================================
Files 117 117
Lines 9733 9733
Branches 329 328 -1
==========================================
+ Hits 7451 7453 +2
+ Misses 2280 2278 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the GitHub Actions workflow for creating release posts by adding the -- separator between the script name and its arguments when using node --run.
- Adds
--before"$VERSION"in the workflow command to properly pass arguments to the npm script - Ensures the version argument is correctly forwarded to the release-post script
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm merging this without a "formal" fast-track approval as a hotfix |
|
ah right, I ran the script directly with |
Fixes #8281
cc @richardlau
While the actions logs don't show it, the actual error that occured here was that the workflow did not correctly pass
v24.11.0as an argument.