-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Update description of process.nextTick() behavior #8578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Clarify the explanation of process.nextTick() in relation to the event loop: The phrase “before moving to the next phase” may be misleading, as it can imply that process.nextTick() waits for the current event-loop phase to complete. In reality, process.nextTick() callbacks run immediately after the current call stack empties, it doesn't wait for the current phase to end. Signed-off-by: Ahmet ULKU <96921013+ahhmettulku@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
@ahhmettulku Can you rebase to resolve an issue on our end? |
|
Hi @avivkeller, done. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8578 +/- ##
==========================================
- Coverage 75.03% 75.02% -0.02%
==========================================
Files 103 103
Lines 9042 9042
Branches 311 311
==========================================
- Hits 6785 6784 -1
- Misses 2255 2256 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Clarify the explanation of process.nextTick() in relation to the event loop: The phrase “before moving to the next phase” may be misleading, as it can imply that process.nextTick() waits for the current event-loop phase to complete. In reality, process.nextTick() callbacks run immediately after the current call stack empties, it doesn't wait for the current phase to end.
Description
I changed the explanation a little bit about the process.nextTick(). The old version could cause misunderstanding.
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.