Skip to content

fix(a11y): improve toggle switches #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdln merged 7 commits into from
Mar 6, 2026
Merged

fix(a11y): improve toggle switches #1782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee1082e
fix(a11y): improve toggle switches
userquin Mar 1, 2026
b36e9c4
chore: restore forced colors
userquin Mar 1, 2026
77eb000
chore: apply coderabbit.ai suggestion for css label selector
userquin Mar 1, 2026
15031a2
Merge branch 'main' into userquin/fix-a11y-toogle-switches
userquin Mar 5, 2026
89ae695
chore: simplify markup adding just the check mark
userquin Mar 5, 2026
4632bbf
feat: update reactions in toggle
alexdln Mar 6, 2026
116ab08
feat: apply suggestion about toggle
alexdln Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 21 additions & 66 deletions app/components/Settings/Toggle.client.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const id = useId()
<template>
<label
:for="id"
class="grid items-center gap-1.5 py-1 -my-1 grid-cols-[auto_1fr_auto]"
class="grid items-center gap-1.5 py-1 -my-1 grid-cols-[auto_1fr_auto] cursor-pointer"
:class="[justify === 'start' ? 'justify-start' : '']"
:style="
props.reverseOrder
Expand All @@ -39,9 +39,9 @@ const id = useId()
<input
role="switch"
type="checkbox"
:id
:id="id"
v-model="checked"
class="toggle appearance-none h-6 w-11 rounded-full border border-fg relative shrink-0 bg-fg-subtle checked:bg-fg checked:border-fg focus-visible:(outline-2 outline-fg outline-offset-2) before:content-[''] before:absolute before:h-5 before:w-5 before:top-1px before:rounded-full before:bg-bg"
class="toggle appearance-none h-6 w-11 rounded-full border border-fg relative shrink-0 bg-fg/50 transition-colors duration-200 ease-in-out checked:bg-fg hover:bg-fg/60 checked:hover:(bg-fg/80 after:opacity-50) focus-visible:(outline-2 outline-accent outline-offset-2) before:(content-[''] absolute h-5 w-5 top-px start-px rounded-full bg-bg transition-transform duration-200 ease-in-out) checked:before:translate-x-[20px] rtl:checked:before:-translate-x-[20px] after:(content-[''] absolute h-3.5 w-3.5 top-[4px] start-[4px] i-lucide:check bg-fg opacity-0 transition-all duration-200 ease-in-out) checked:after:opacity-100 checked:after:translate-x-[20px] rtl:checked:after:-translate-x-[20px]"
style="grid-area: toggle"
/>
<TooltipApp
Expand Down Expand Up @@ -85,9 +85,9 @@ const id = useId()
<input
role="switch"
type="checkbox"
:id
:id="id"
v-model="checked"
class="toggle appearance-none h-6 w-11 rounded-full border border-fg relative shrink-0 bg-fg-subtle checked:bg-fg checked:border-fg focus-visible:(outline-2 outline-fg outline-offset-2) before:content-[''] before:absolute before:h-5 before:w-5 before:top-1px before:rounded-full before:bg-bg"
class="toggle appearance-none h-6 w-11 rounded-full border border-fg relative shrink-0 bg-fg/50 transition-colors duration-200 ease-in-out checked:bg-fg hover:bg-fg/60 checked:hover:(bg-fg/80 after:opacity-50) focus-visible:(outline-2 outline-accent outline-offset-2) before:(content-[''] absolute h-5 w-5 top-px start-px rounded-full bg-bg transition-transform duration-200 ease-in-out) checked:before:translate-x-[20px] rtl:checked:before:-translate-x-[20px] after:(content-[''] absolute h-3.5 w-3.5 top-[4px] start-[4px] i-lucide:check bg-fg opacity-0 transition-all duration-200 ease-in-out) checked:after:opacity-100 checked:after:translate-x-[20px] rtl:checked:after:-translate-x-[20px]"
style="grid-area: toggle; justify-self: end"
/>
</template>
Expand All @@ -98,82 +98,37 @@ const id = useId()
</template>

<style scoped>
/* Thumb position: logical property for RTL support */
.toggle::before {
inset-inline-start: 1px;
}

/* Track transition */
.toggle {
transition:
background-color 200ms ease-in-out,
border-color 100ms ease-in-out;
}

.toggle::before {
transition:
background-color 200ms ease-in-out,
translate 200ms ease-in-out;
}

/* Hover states */
.toggle:hover:not(:checked) {
background: var(--fg-muted);
}

.toggle:checked:hover {
background: var(--fg-muted);
border-color: var(--fg-muted);
}

/* RTL-aware checked thumb position */
:dir(ltr) .toggle:checked::before {
translate: 20px;
}

:dir(rtl) .toggle:checked::before {
translate: -20px;
}

@media (prefers-reduced-motion: reduce) {
.toggle,
.toggle::before {
transition: none;
}
}

/* Support forced colors */
@media (forced-colors: active) {
label > span {
.toggle {
background: Canvas;
color: Highlight;
forced-color-adjust: none;
border-color: CanvasText;
}

label:has(.toggle:checked) > span {
.toggle:checked {
background: Highlight;
color: Canvas;
border-color: CanvasText;
}

.toggle::before {
forced-color-adjust: none;
background-color: Highlight;
background-color: CanvasText;
}

.toggle,
.toggle:hover {
background: Canvas;
border-color: CanvasText;
.toggle:checked::before {
background-color: Canvas;
}

.toggle:checked,
.toggle:checked:hover {
background: Highlight;
border-color: CanvasText;
.toggle::after {
background-color: Highlight;
}
}

.toggle:checked::before {
background: Canvas;
@media (prefers-reduced-motion: reduce) {
.toggle,
.toggle::before,
.toggle::after {
transition: none !important;
animation: none !important;
}
}
</style>
87 changes: 5 additions & 82 deletions app/components/Settings/Toggle.server.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ const props = withDefaults(
label: string
description?: string
justify?: 'between' | 'start'
tooltip?: string
tooltipPosition?: 'top' | 'bottom' | 'left' | 'right'
tooltipTo?: string
tooltipOffset?: number
reverseOrder?: boolean
}>(),
{
Expand All @@ -15,7 +19,7 @@ const props = withDefaults(

<template>
<div
class="grid items-center gap-4 py-1 -my-1 grid-cols-[auto_1fr_auto]"
class="grid items-center gap-1.5 py-1 -my-1 grid-cols-[auto_1fr_auto]"
:class="[justify === 'start' ? 'justify-start' : '']"
:style="
props.reverseOrder
Expand Down Expand Up @@ -51,84 +55,3 @@ const props = withDefaults(
{{ description }}
</p>
</template>

<style scoped>
/* Thumb position: logical property for RTL support */
.toggle::before {
inset-inline-start: 1px;
}

/* Track transition */
.toggle {
transition:
background-color 200ms ease-in-out,
border-color 100ms ease-in-out;
}

.toggle::before {
transition:
background-color 200ms ease-in-out,
translate 200ms ease-in-out;
}

/* Hover states */
.toggle:hover:not(:checked) {
background: var(--fg-muted);
}

.toggle:checked:hover {
background: var(--fg-muted);
border-color: var(--fg-muted);
}

/* RTL-aware checked thumb position */
:dir(ltr) .toggle:checked::before {
translate: 20px;
}

:dir(rtl) .toggle:checked::before {
translate: -20px;
}

@media (prefers-reduced-motion: reduce) {
.toggle,
.toggle::before {
transition: none;
}
}

/* Support forced colors */
@media (forced-colors: active) {
label > span {
background: Canvas;
color: Highlight;
forced-color-adjust: none;
}

label:has(.toggle:checked) > span {
background: Highlight;
color: Canvas;
}

.toggle::before {
forced-color-adjust: none;
background-color: Highlight;
}

.toggle,
.toggle:hover {
background: Canvas;
border-color: CanvasText;
}

.toggle:checked,
.toggle:checked:hover {
background: Highlight;
border-color: CanvasText;
}

.toggle:checked::before {
background: Canvas;
}
}
</style>
Loading