Skip to content

fix: use resolvedVersion on package page to display data correctly #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex-key wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −11
Open

fix: use resolvedVersion on package page to display data correctly #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f458531
fix: use pkg resolved version on package page to display data correctly
alex-key Mar 6, 2026
3907a78
fix: use hash for get bluesky profiles cache key
alex-key Mar 6, 2026
7d0669b
Merge branch 'main' into fix/range-version-empty-readme
alexdln Mar 7, 2026
cc989d5
Merge branch 'main' into fix/range-version-empty-readme
alex-key Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ const navExtraOffsetStyle = computed(() => ({

const { packageName, requestedVersion, orgName } = usePackageRoute()

const { data: resolvedVersion, status: resolvedStatus } = await useResolvedVersion(
packageName,
requestedVersion,
)

if (import.meta.server) {
assertValidPackageName(packageName.value)
}
Expand All @@ -114,7 +119,7 @@ if (import.meta.server) {
const { data: readmeData } = useLazyFetch<ReadmeResponse>(
() => {
const base = `/api/registry/readme/${packageName.value}`
const version = requestedVersion.value
const version = resolvedVersion.value
return version ? `${base}/v/${version}` : base
},
{
Expand Down Expand Up @@ -150,7 +155,7 @@ const {
} = useLazyFetch<ReadmeMarkdownResponse>(
() => {
const base = `/api/registry/readme/markdown/${packageName.value}`
const version = requestedVersion.value
const version = resolvedVersion.value
return version ? `${base}/v/${version}` : base
},
{
Expand Down Expand Up @@ -200,7 +205,7 @@ const {
} = useLazyFetch<InstallSizeResult | null>(
() => {
const base = `/api/registry/install-size/${packageName.value}`
const version = requestedVersion.value
const version = resolvedVersion.value
return version ? `${base}/v/${version}` : base
},
{
Expand All @@ -213,7 +218,7 @@ onMounted(() => fetchInstallSize())
const { data: skillsData } = useLazyFetch<SkillsListResponse>(
() => {
const base = `/skills/${packageName.value}`
const version = requestedVersion.value
const version = resolvedVersion.value
return version ? `${base}/v/${version}` : base
},
{ default: () => ({ package: '', version: '', skills: [] }) },
Expand All @@ -222,11 +227,6 @@ const { data: skillsData } = useLazyFetch<SkillsListResponse>(
const { data: packageAnalysis } = usePackageAnalysis(packageName, requestedVersion)
const { data: moduleReplacement } = useModuleReplacement(packageName)

const { data: resolvedVersion, status: resolvedStatus } = await useResolvedVersion(
packageName,
requestedVersion,
)

if (
import.meta.server &&
!resolvedVersion.value &&
Expand Down Expand Up @@ -1369,7 +1369,7 @@ const showSkeleton = shallowRef(false)
</div>
<TerminalInstall
:package-name="pkg.name"
:requested-version="requestedVersion ? resolvedVersion : requestedVersion"
:requested-version="resolvedVersion"
:install-version-override="installVersionOverride"
:jsr-info="jsrInfo"
:dev-dependency-suggestion="packageAnalysis?.devDependencySuggestion"
Expand Down
7 changes: 6 additions & 1 deletion server/api/atproto/bluesky-author-profiles.get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as v from 'valibot'
import crypto from 'node:crypto'
import { CACHE_MAX_AGE_ONE_DAY, BLUESKY_API } from '#shared/utils/constants'
import { AuthorSchema } from '#shared/schemas/blog'
import { Client } from '@atproto/lex'
Expand Down Expand Up @@ -75,7 +76,11 @@ export default defineCachedEventHandler(
maxAge: CACHE_MAX_AGE_ONE_DAY,
getKey: event => {
const { authors } = getQuery(event)
return `author-profiles:${authors ?? 'npmx.dev'}`
const hash = crypto
.createHash('md5')
.update(JSON.stringify(authors ?? 'npmx.dev'))
.digest('hex')
return `author-profiles:${hash}`
},
},
)
Loading