fix: remove border in package suggestion dropdown items#1970
fix: remove border in package suggestion dropdown items#1970serhalp merged 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request applies styling modifications to the PackageSelector component's typeahead dropdown. Specifically, the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks. 😊 |
On the Compare page (/compare), the package search dropdown items had visible borders in light theme but NOT in dark theme, creating an inconsistent look.
Each dropdown item uses
ButtonBase, which has border border-border in its base classes. The --border color token resolves to oklch(0.8514 0 0) in light theme (visible against --bg-elevated) and oklch(0.269 0 0) in dark theme (blends with the dark background).Added
!border-transparentto the twoButtonBaseusages inside the dropdown inPackageSelector.vuemaking item borders invisible in both themes while preserving all other button behavior.Before:
After: