Skip to content

fix: remove border in package suggestion dropdown items#1970

Merged
serhalp merged 2 commits intonpmx-dev:mainfrom
iiio2:fix/remove-border-in-package-suggestion
Mar 8, 2026
Merged

fix: remove border in package suggestion dropdown items#1970
serhalp merged 2 commits intonpmx-dev:mainfrom
iiio2:fix/remove-border-in-package-suggestion

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Mar 7, 2026

On the Compare page (/compare), the package search dropdown items had visible borders in light theme but NOT in dark theme, creating an inconsistent look.

Each dropdown item uses ButtonBase, which has border border-border in its base classes. The --border color token resolves to oklch(0.8514 0 0) in light theme (visible against --bg-elevated) and oklch(0.269 0 0) in dark theme (blends with the dark background).

Added !border-transparent to the two ButtonBase usages inside the dropdown in PackageSelector.vue making item borders invisible in both themes while preserving all other button behavior.

Before:

before

After:

after

@vercel
Copy link

vercel bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 7, 2026 11:29pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 7, 2026 11:29pm
npmx-lunaria Ignored Ignored Mar 7, 2026 11:29pm

Request Review

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Compare/PackageSelector.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7f36cb3a-cbf0-4ba2-bbb7-66ed3b574994

📥 Commits

Reviewing files that changed from the base of the PR and between 0d952fa and 0d92d7f.

📒 Files selected for processing (1)
  • app/components/Compare/PackageSelector.vue

📝 Walkthrough

Walkthrough

The pull request applies styling modifications to the PackageSelector component's typeahead dropdown. Specifically, the !border-transparent class is added to two ButtonBase items: the No Dependency option button and individual result items. These are purely presentational changes to the dropdown styling, with no alterations to component logic or data flow.

Possibly related PRs

  • PR 1377 in npmx-dev/npmx.dev: Both PRs modify the same UI elements in PackageSelector.vue — this PR adds !border-transparent to ButtonBase dropdown items whilst the retrieved PR restructures those dropdown items for keyboard navigation support.
  • PR 941 in npmx-dev/npmx.dev: Both PRs make styling adjustments in PackageSelector.vue, tweaking CSS classes on button and icon elements.

Suggested reviewers

  • whitep4nth3r
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the visual inconsistency being fixed, details the technical root cause of the theme-dependent border visibility, and describes the solution applied to PackageSelector.vue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalp serhalp added this pull request to the merge queue Mar 8, 2026
Merged via the queue into npmx-dev:main with commit c2e7230 Mar 8, 2026
20 checks passed
@iiio2
Copy link
Contributor Author

iiio2 commented Mar 8, 2026

Thanks. 😊

@iiio2 iiio2 deleted the fix/remove-border-in-package-suggestion branch March 8, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants