Skip to content

fix: adjust logo sizing on about page#1986

Open
vladh wants to merge 3 commits intonpmx-dev:mainfrom
vladh:main
Open

fix: adjust logo sizing on about page#1986
vladh wants to merge 3 commits intonpmx-dev:mainfrom
vladh:main

Conversation

@vladh
Copy link
Contributor

@vladh vladh commented Mar 7, 2026

🔗 Linked issue

N/A

🧭 Context

Currently, the logo grid on the about page has some issues.

First, the hover background is uneven, and in some parts is close to colliding with the logos. In particular, look at the lack of horizontal spacing on the Vercel logo, and the general lack of spacing on the Open Source Pledge logo.

Screen Shot 2026-03-07 at 22 45 47

Secondly, some logos are much bigger than others, which makes them look out of place, and also makes the whole grid more irregular. Look at the Nuxt and Vue.js logos, and how big they are relative to the logos above and below them.

2026-03-07-22-47-25

📚 Description

I added more padding to all of the logos.

I replaced the previous per-logo padding-block adjustment with a more reliable per-logo max-height adjustment. This makes it easier to make the logos look consistent with each other.

I added a negative horizontal margin to the logo container, so that logos are flush with the left and right edges.

I generally adjusted all dimensions to make the logos look better.

cc @alexdln 🙏🏻

Before and after, no hover

Before

Screen Shot 2026-03-07 at 22 43 20

After

Screen Shot 2026-03-07 at 22 43 24

Before and after, with hover background (all hover effects enabled for illustration)

Before

Screen Shot 2026-03-07 at 22 45 47

After

Screen Shot 2026-03-07 at 22 45 52

Before and after on mobile

Before

Screen Shot 2026-03-07 at 22 46 53

After

Screen Shot 2026-03-07 at 22 46 56

@vercel
Copy link

vercel bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 7, 2026 11:37pm
npmx.dev (canary) Ready Ready Preview, Comment Mar 7, 2026 11:37pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 7, 2026 11:37pm

Request Review

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@vladh
Copy link
Contributor Author

vladh commented Mar 7, 2026

Test failures seem unrelated.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f82bab19-4ff5-4041-9e38-425ed548ec0b

📥 Commits

Reviewing files that changed from the base of the PR and between 0d952fa and eb87280.

📒 Files selected for processing (3)
  • app/assets/logos/oss-partners/index.ts
  • app/assets/logos/sponsors/index.ts
  • app/components/About/LogoList.vue

📝 Walkthrough

Walkthrough

This pull request modifies logo configuration across three files to standardise sizing constraints. The OSS_PARTNERS array receives new maxHeight properties for Nuxt, Vue, and Vue Data UI entries. The SPONSORS array replaces the normalisingIndent field with maxHeight for Vercel, Void Zero, vlt, and Bluesky entries, whilst removing normalisingIndent from Netlify entirely. The LogoList component's BaseItem type signature is updated to use maxHeight instead of normalisingIndent, with corresponding style bindings and layout adjustments to padding and height values.

Possibly related PRs

Suggested reviewers

  • alexdln
  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the issues (uneven hover background, oversized logos) and describes the solutions implemented (added padding, replaced padding-block with max-height, added negative margin, adjusted dimensions).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants