Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Test failures seem unrelated. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request modifies logo configuration across three files to standardise sizing constraints. The OSS_PARTNERS array receives new maxHeight properties for Nuxt, Vue, and Vue Data UI entries. The SPONSORS array replaces the normalisingIndent field with maxHeight for Vercel, Void Zero, vlt, and Bluesky entries, whilst removing normalisingIndent from Netlify entirely. The LogoList component's BaseItem type signature is updated to use maxHeight instead of normalisingIndent, with corresponding style bindings and layout adjustments to padding and height values. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
N/A
🧭 Context
Currently, the logo grid on the about page has some issues.
First, the hover background is uneven, and in some parts is close to colliding with the logos. In particular, look at the lack of horizontal spacing on the Vercel logo, and the general lack of spacing on the Open Source Pledge logo.
Secondly, some logos are much bigger than others, which makes them look out of place, and also makes the whole grid more irregular. Look at the Nuxt and Vue.js logos, and how big they are relative to the logos above and below them.
📚 Description
I added more padding to all of the logos.
I replaced the previous per-logo
padding-blockadjustment with a more reliable per-logomax-heightadjustment. This makes it easier to make the logos look consistent with each other.I added a negative horizontal margin to the logo container, so that logos are flush with the left and right edges.
I generally adjusted all dimensions to make the logos look better.
cc @alexdln 🙏🏻
Before and after, no hover
Before
After
Before and after, with hover background (all hover effects enabled for illustration)
Before
After
Before and after on mobile
Before
After