Align images for multiline titles in CS section#608
Open
ernestofgonzalez wants to merge 3 commits intonumpy:mainfrom
Open
Align images for multiline titles in CS section#608ernestofgonzalez wants to merge 3 commits intonumpy:mainfrom
ernestofgonzalez wants to merge 3 commits intonumpy:mainfrom
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
ernestofgonzalez
left a comment
ernestofgonzalez
left a comment
There was a problem hiding this comment.
The auto margin bottom was from another experiment I was running. I had forgot to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-416
static/images/content_images/case_studies/deeplabcut.pnghas different aspect ratio than the rest, which resulted in misalignment with other cards in 2x2 grid.A note on point 2: A more interesting approach could be to check the number of lines of the longest title and set the line height of all titles to the line height of that one. I tried this but couldn't make the height of the card to update accordingly.