bugfix: add "to yml" command#15254
Conversation
sholderbach
left a comment
There was a problem hiding this comment.
Thanks!
I was thinking if we could get by with a .nu version of this as part of the std prelude. But supporting all the flags and documentation like this may still be kind of messy. So I am fine with the Rust-duplication alias.
Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
I thought the duplication was okay because that's already the case for |
Also what's your take on this? |
Yeah fine based on precedent as well. Let's go with this approach for now
I think it suffices that the command will appear in the autogenerated command help. |
Sure! How does it work, do I just push a new commit on the |
|
If you edit it in the web interface it will probably ask you to open a PR. If you start your changes locally, you will have to set the target branch of the PR to |
|
Hi @sholderbach I did that PR for the release note but I think nobody saw it |
|
Thanks! Sorry that I didn't get around to it. Nice user-friendly writeup! |
Description
This fixes #15240, which can be closed after merge.
User-Facing Changes
to yml-> exactly the same asto yamlTests + Formatting
Cargo fmt and clippy 🆗
I added a test in the only place I could find where
to yamlwas already tested.I didn't see the
save.rs::convert_to_extensionfunction tested anywhere, but maybe I missed it.After Submitting
Not sure this needs an update on the documentation ❓ What do you suggest?