Skip to content

Conversation

@SylvainJuge
Copy link
Contributor

This is an early prototype implementation of servlet request body capture.
The goal of this PR is to gather feedback on the suggested approach and having this feature provided (but opt-in) by default.

  • adds otel.instrumentation.servlet.experimental.capture-request-body=true|false config option
  • maximum body size is not configurable (yet)
  • body capture implemented by copying in-memory (duplicates in-memory)
  • limited to request body
  • limited to Servlet 5.x for now
  • limited to Servlet.getInputStream(), Servlet.getReader() not supported

Relates to #8778

…nstrumentation into capture-servlet-request-body

# Conflicts:
#	instrumentation/servlet/servlet-5.0/tomcat-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v5_0/tomcat/TomcatServlet5Test.java
#	instrumentation/servlet/servlet-5.0/tomcat-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v5_0/tomcat/dispatch/TomcatServlet5DispatchAsyncTest.java
#	instrumentation/servlet/servlet-5.0/tomcat-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v5_0/tomcat/dispatch/TomcatServlet5DispatchImmediateTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant