Skip to content

Change GlobUtil, IncludeExcludePredicate to use case sensitive matching consistently#8152

Merged
jack-berg merged 4 commits intoopen-telemetry:mainfrom
jack-berg:case-sensitive-matching
Mar 6, 2026
Merged

Change GlobUtil, IncludeExcludePredicate to use case sensitive matching consistently#8152
jack-berg merged 4 commits intoopen-telemetry:mainfrom
jack-berg:case-sensitive-matching

Conversation

@jack-berg
Copy link
Member

Resolves #8137.

@jack-berg jack-berg requested a review from a team as a code owner March 6, 2026 18:24
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (bc73a5e) to head (5cecf3c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8152   +/-   ##
=========================================
  Coverage     90.29%   90.29%           
+ Complexity     7650     7649    -1     
=========================================
  Files           843      843           
  Lines         23059    23059           
  Branches       2309     2309           
=========================================
+ Hits          20821    20822    +1     
+ Misses         1519     1518    -1     
  Partials        719      719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@trask
Copy link
Member

trask commented Mar 6, 2026

do we need also to include

// Exact match, ignoring case
return globPattern.equalsIgnoreCase(s);

@jack-berg
Copy link
Member Author

do we need also to include

Pushed a commit to extend to GlobUtil, but this definitely widens the scope of impact, since metric view name selection is impacted.

I still characterize this as a bug fix, since as GlobUtilTest updates show, the pattern matching portion of was still case sensitive despite the exact match being case insensitive. One way or the other, we have to make it consistent, and I see no language in the spec to suggest that view metric name matching, glob patterns, or matching in general should be case insensitive.

@jack-berg jack-berg changed the title Change IncludeExcludePredicate to use case sensitive matching consistently Change GlobUtil, IncludeExcludePredicate to use case sensitive matching consistently Mar 6, 2026
@trask
Copy link
Member

trask commented Mar 6, 2026

characterize this as a bug fix

👍

@jack-berg jack-berg merged commit c1820bf into open-telemetry:main Mar 6, 2026
27 checks passed
jack-berg added a commit that referenced this pull request Mar 6, 2026
github-actions bot pushed a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IncludeExcludePredicate case sensitivity inconsistency

3 participants