Change GlobUtil, IncludeExcludePredicate to use case sensitive matching consistently#8152
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8152 +/- ##
=========================================
Coverage 90.29% 90.29%
+ Complexity 7650 7649 -1
=========================================
Files 843 843
Lines 23059 23059
Branches 2309 2309
=========================================
+ Hits 20821 20822 +1
+ Misses 1519 1518 -1
Partials 719 719 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
do we need also to include |
Pushed a commit to extend to GlobUtil, but this definitely widens the scope of impact, since metric view name selection is impacted. I still characterize this as a bug fix, since as GlobUtilTest updates show, the pattern matching portion of was still case sensitive despite the exact match being case insensitive. One way or the other, we have to make it consistent, and I see no language in the spec to suggest that view metric name matching, glob patterns, or matching in general should be case insensitive. |
sdk/common/src/main/java/io/opentelemetry/sdk/common/internal/IncludeExcludePredicate.java
Outdated
Show resolved
Hide resolved
👍 |
…ng consistently (#8152)
Resolves #8137.