fix(tracing): drop unsupported usage fields for OpenAI trace ingest#2445
Closed
OiPunk wants to merge 2 commits intoopenai:mainfrom
Closed
fix(tracing): drop unsupported usage fields for OpenAI trace ingest#2445OiPunk wants to merge 2 commits intoopenai:mainfrom
OiPunk wants to merge 2 commits intoopenai:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc5317189b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
seratch
approved these changes
Feb 9, 2026
Member
|
Closing this in favor of #2448 (the credit for your contribution is kept) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the tracing regression reported in #2444 where OpenAI trace ingestion rejects payloads containing
span_data.usage.requests.Root cause
GenerationSpanData.usagestarted including SDK-specific fields such asrequests. The OpenAI tracing ingestion endpoint does not accept that field and returns:Unknown parameter: 'data[...].span_data.usage.requests'Changes
BackendSpanExporterbefore POST.input_tokensoutput_tokenstotal_tokensinput_tokens_detailsoutput_tokens_detailsrequests)Validation
uv run ruff check src/agents/tracing/processors.py tests/test_trace_processor.pyenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy uv run mypy src/agents/tracing/processors.pyenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy uv run pytest -q tests/tracing/test_processor_api_key.py tests/test_trace_processor.pyenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy uv run coverage run -m pytest -q tests/test_trace_processor.pyenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy uv run coverage report -m src/agents/tracing/processors.pyChanged-line coverage for
src/agents/tracing/processors.pyis 100%.