perf: use deque for BFS queue and voice task ordering#2559
Merged
seratch merged 2 commits intoopenai:mainfrom Feb 28, 2026
Merged
perf: use deque for BFS queue and voice task ordering#2559seratch merged 2 commits intoopenai:mainfrom
seratch merged 2 commits intoopenai:mainfrom
Conversation
- run_state.py: _build_agent_map() BFS traversal uses list.pop(0) which is O(n) per removal. Switch to collections.deque with popleft() for O(1). - voice/result.py: _ordered_tasks consumed front-to-back via .pop(0), same O(n) issue. Switch to deque with popleft(). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
Can you fix the lint error? |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Fixed — reformatted |
seratch
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two hot paths use
list.pop(0)which is O(n) per removal:run_state.py—_build_agent_map(): BFS traversal over agent handoff graph. Each.pop(0)shifts all remaining elements.voice/result.py—_ordered_tasks: Voice pipeline drains ordered task queues front-to-back. Each.pop(0)is O(n).Solution
Switch both to
collections.dequewith.popleft()for O(1) front removal.Changes
src/agents/run_state.py: Importdeque, usedeque([initial_agent])and.popleft()src/agents/voice/result.py: Importdeque, type_ordered_tasksasdeque, use.popleft()Testing
ast.parse()