USHIFT-6519: RHEL 9.8 in bootc presubmits and periodics - remaining fixes#6270
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
@ggiguash: This pull request references USHIFT-6519 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughRelaxed RPM Requires ranges for cri-o and cri-tools; boot-source references in two upgrade test scripts changed from RHEL96 to RHEL98; rollback test added a TestAgent.Add action for "next deployment" and removed the fixed "Expected Boot Count 5" assertion. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test ? |
|
/test e2e-aws-tests-bootc |
openshift-ci
bot
added
the
approved
|
/test e2e-aws-tests-bootc |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@ggiguash: This pull request references USHIFT-6519 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
test/scenarios-bootc/presubmits/el96-yminus2@prel@src@delta-upgrade-ok.sh (1)
18-21: Consider renaming the file to reflectel98-src.The
srcsegment in the filename is now ambiguously unversioned —rhel98-bootc-sourceis the target. A related file in this same PR usesel98-srcexplicitly (el96-yminus2@el98-src@upgrade-ok.sh). Renaming toel96-yminus2@prel@el98-src@delta-upgrade-ok.shwould align the naming convention.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/scenarios-bootc/presubmits/el96-yminus2`@prel@src@delta-upgrade-ok.sh around lines 18 - 21, Rename the test file currently named "el96-yminus2@prel@src@delta-upgrade-ok.sh" to explicitly reference the target source version; update it to "el96-yminus2@prel@el98-src@delta-upgrade-ok.sh" so the filename aligns with the existing companion "el96-yminus2@el98-src@upgrade-ok.sh" and removes ambiguity of the "src" segment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packaging/rpm/microshift.spec`:
- Around line 67-70: Replace the TODO about cri-tools with a strict version
constraint and a release gate reference: update the RPM spec requirement for
cri-tools (the entry that currently references the TODO) to require cri-tools >=
1.35.0 (matching CRI-O 1.35.x) and add a short comment pointing to the release
policy/Jira ticket that enforces this gate so the relaxed constraint cannot be
shipped accidentally; ensure the change touches the spec "Requires:"/package
dependency line that currently contains the TODO and add the Jira ID or
release-gate marker in that same comment.
---
Nitpick comments:
In `@test/scenarios-bootc/presubmits/el96-yminus2`@prel@src@delta-upgrade-ok.sh:
- Around line 18-21: Rename the test file currently named
"el96-yminus2@prel@src@delta-upgrade-ok.sh" to explicitly reference the target
source version; update it to "el96-yminus2@prel@el98-src@delta-upgrade-ok.sh" so
the filename aligns with the existing companion
"el96-yminus2@el98-src@upgrade-ok.sh" and removes ambiguity of the "src"
segment.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (4)
packaging/rpm/microshift.spectest/scenarios-bootc/presubmits/el96-yminus2@el98-src@upgrade-ok.shtest/scenarios-bootc/presubmits/el96-yminus2@prel@src@delta-upgrade-ok.shtest/suites/upgrade/upgrade-fails-and-rolls-back.robot
|
@ggiguash: This pull request references USHIFT-6519 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-bootc-periodic |
ggiguash
force-pushed
the
rhel98-release-bootc
branch
from
d6c1548 to
58c7d20
Compare
|
@ggiguash: This pull request references USHIFT-6519 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-bootc-periodic |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/suites/upgrade/upgrade-fails-and-rolls-back.robot`:
- Around line 38-40: The test lost reboot-count validation after rollback:
update the rollback flow (the Deploy Commit Expecting A Rollback keyword in
ostree.resource around the Deploy Commit Expecting A Rollback implementation) to
assert the system boot count by calling the Expected Boot Count keyword once
rollback completes, or if intended, add a comment and cross-check that another
mechanism verifies reboot counts; ensure you reference the Deploy Commit
Expecting A Rollback keyword and add an explicit Expected Boot Count invocation
immediately after the rollback completion path so the test revalidates the
reboot count.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
test/suites/upgrade/upgrade-fails-and-rolls-back.robot
…nboot behavior change
|
/test e2e-aws-tests-bootc-periodic |
|
@ggiguash: This pull request references USHIFT-6519 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The failures are flakes. Overriding to save on CI cycles. |
openshift-ci-robot
added
the
verified
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-bootc, ci/prow/e2e-aws-tests-bootc-periodic DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Fixing aftermath of #6202
Also addresses USHIFT-6521
Note: Implemented a temporary workaround for the greenboot behavior change by disabling some scenarios. The fix will be done in USHIFT-6636
Summary by CodeRabbit
Chores
Tests