feat: support additional java CRDs in test extension #3163
Conversation
Adds withAdditionalCustomResourceDefinition(CustomResourceDefinition definition) to LocallyRunOperatorExtension#Builder. These definitions are applied at the same time as additionalCustomResourceDefinitions. The definitions are deleted according to the existing lifecycle. Why: In some cases we may wish to apply a CustomResourceDefinition that has no corresponding CRD file. For example, some frameworks publish fabric8-based api modules which contain only the java classes and no CRD files. Signed-off-by: Robert Young <robertyoungnz@gmail.com>
| public void applyCrd(CustomResourceDefinition customResourceDefinition) { | ||
| try { | ||
| String resourceTypeName = customResourceDefinition.getMetadata().getName(); | ||
| final var pathAsString = crdMappings.get(resourceTypeName); |
There was a problem hiding this comment.
I am unsure whether this logic should be applied.
For the other mechanism withAdditionalCustomResourceDefinition(Class<? extends CustomResource> customResource) { it checks the custom crdMappings first and prefers to apply a CRD supplied there, else it looks in the standard location.
What should we do if the crdMappings contains a CRD with the same name as this CustomResourceDefinition?
There was a problem hiding this comment.
IMHO, we should check if we already applied CRD with same name, if yes throw an exception, since probably that is not what user intends. This can be a separate PR.
|
@xstefank pls take a look also |
| public void applyCrd(CustomResourceDefinition customResourceDefinition) { | ||
| try { | ||
| String resourceTypeName = customResourceDefinition.getMetadata().getName(); | ||
| final var pathAsString = crdMappings.get(resourceTypeName); |
There was a problem hiding this comment.
IMHO, we should check if we already applied CRD with same name, if yes throw an exception, since probably that is not what user intends. This can be a separate PR.
|
@robobario @xstefank if you have the bandwidth and could do the duplicate detection would be great, but mainly thank you for this PR. |
|
@robobario if that helps we can have a patch release this week for you |
|
thanks @csviri we have a workaround in place so there's no urgency to release, whenever suits you |
3 participants
Adds
withAdditionalCustomResourceDefinition(CustomResourceDefinition definition)toLocallyRunOperatorExtension#Builder. These definitions are applied at the same time as the existingadditionalCustomResourceDefinitions. The definitions are deleted according to the existing lifecycle.Resolves #3004
Why:
In some cases we may wish to apply a CustomResourceDefinition that has no corresponding CRD file. For example, some frameworks publish fabric8-based api modules which contain only the java classes for their CRDs, and no CRD files.