🌱 Replace deprecated marker for required fields by camilamacedo86 · Pull Request #2407 · operator-framework/operator-controller

camilamacedo86 · 2025-12-23T15:27:19Z

The redundante marker should no longer be used.
More info: kubernetes-sigs/controller-tools#1241

Motivation
kube-api-linter only recognize // +required and not the kubebuilder marker

netlify · 2025-12-23T15:27:24Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`d678562`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6980ff980e1755000828ed53
😎 Deploy Preview	https://deploy-preview-2407--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR modernizes the API type definitions by replacing the deprecated +kubebuilder:validation:Required marker with the newer +required marker across all API types. The change is purely a marker update with no functional impact on the generated CRDs.

Replaces +kubebuilder:validation:Required with +required in all API type definitions
Updates auto-generated API reference documentation to reflect the new marker format
Applies the change consistently across ClusterExtension, ClusterExtensionRevision, and ClusterCatalog types

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`hack/tools/crd-generator/testdata/api/v1/clusterextension_types.go`	Updates test data for CRD generator with new required field marker
`api/v1/clusterextension_types.go`	Replaces deprecated required marker in ClusterExtension type definitions
`api/v1/clusterextensionrevision_types.go`	Replaces deprecated required marker in ClusterExtensionRevision type definitions
`api/v1/clustercatalog_types.go`	Replaces deprecated required marker in ClusterCatalog type definitions
`docs/api-reference/olmv1-api-reference.md`	Updates auto-generated API documentation to reflect new marker format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2025-12-23T15:42:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.53%. Comparing base (e224f78) to head (d678562).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   69.55%   69.53%   -0.03%     
==========================================
  Files         102      102              
  Lines        8354     8354              
==========================================
- Hits         5811     5809       -2     
- Misses       2079     2080       +1     
- Partials      464      465       +1

Flag	Coverage Δ
e2e	`46.83% <ø> (ø)`
experimental-e2e	`13.14% <ø> (ø)`
unit	`57.49% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

docs/api-reference/olmv1-api-reference.md

camilamacedo86 · 2026-01-05T23:52:14Z

When we have a new release with elastic/crd-ref-docs#192 we can check this one again.
For now, I am closing.

camilamacedo86 · 2026-02-02T23:29:59Z

/hold cancel

camilamacedo86 · 2026-02-03T07:32:21Z

The linter check mark as solved the usage of the deprecated markers
But then because now we are using the marker recognize by it also raise new linter issues about the fields
See: https://github.com/operator-framework/operator-controller/actions/runs/21610044146/job/62276455199?pr=2407

So, we must override

/override api-diff-lint

/override lint-api-diff

openshift-ci · 2026-02-03T07:32:27Z

@camilamacedo86: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

api-diff-lint

Only the following failed contexts/checkruns were expected:

Verify PR title
crd-diff
e2e
experimental-e2e
extension-developer-e2e
go-apidiff
go-verdiff
goreleaser
lint
lint-api-diff
netlify/olmv1/deploy-preview
st2ex-e2e
tide
unit-test-basic
upgrade-st2st-e2e
verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

The linter check mark as solved the usage of the deprecated markers
But then because now we are using the marker recognize by it also raise new linter issues about the fields
See: https://github.com/operator-framework/operator-controller/actions/runs/21610044146/job/62276455199?pr=2407

So, we must override

/override api-diff-lint

/override lint-api-diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86 · 2026-02-03T07:32:51Z

/override api-diff-lint-override

openshift-ci · 2026-02-03T07:33:05Z

@camilamacedo86: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

api-diff-lint-override

Only the following failed contexts/checkruns were expected:

Verify PR title
crd-diff
e2e
experimental-e2e
extension-developer-e2e
go-apidiff
go-verdiff
goreleaser
lint
lint-api-diff
netlify/olmv1/deploy-preview
st2ex-e2e
tide
unit-test-basic
upgrade-st2st-e2e
verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override api-diff-lint-override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tmshort · 2026-02-03T15:53:24Z

/lgtm

rashmigottipati

/lgtm

pedjak · 2026-02-03T16:06:02Z

/approve

openshift-ci · 2026-02-03T16:06:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [pedjak]
~~hack/OWNERS~~ [pedjak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI review requested due to automatic review settings December 23, 2025 15:27

camilamacedo86 requested a review from a team as a code owner December 23, 2025 15:27

openshift-ci bot requested review from bentito and trgeiger December 23, 2025 15:27

Copilot started reviewing on behalf of camilamacedo86 December 23, 2025 15:27 View session

Copilot AI reviewed Dec 23, 2025

View reviewed changes

camilamacedo86 changed the title ~~🌱 Replace deprecated marker for required fields~~ WIP 🌱 Replace deprecated marker for required fields Dec 23, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2025

camilamacedo86 closed this Dec 23, 2025

camilamacedo86 reopened this Dec 23, 2025

camilamacedo86 changed the title ~~WIP 🌱 Replace deprecated marker for required fields~~ 🌱 Replace deprecated marker for required fields Dec 23, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2025

camilamacedo86 changed the title ~~🌱 Replace deprecated marker for required fields~~ WIP 🌱 Replace deprecated marker for required fields Dec 23, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2025

camilamacedo86 commented Dec 23, 2025

View reviewed changes

docs/api-reference/olmv1-api-reference.md Outdated Show resolved Hide resolved

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2025

camilamacedo86 changed the title ~~WIP 🌱 Replace deprecated marker for required fields~~ (Blocked by https://github.com/elastic/crd-ref-docs/pull/192) 🌱 Replace deprecated marker for required fields Dec 24, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025

camilamacedo86 closed this Jan 5, 2026

camilamacedo86 reopened this Feb 2, 2026

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2026

camilamacedo86 closed this Feb 2, 2026

camilamacedo86 reopened this Feb 2, 2026

camilamacedo86 force-pushed the fix-deprecation branch from fe4bc7e to 8f5cdde Compare February 2, 2026 18:23

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2026

camilamacedo86 changed the title ~~(Blocked by https://github.com/elastic/crd-ref-docs/pull/192) 🌱 Replace deprecated marker for required fields~~ (Blocked by #2477) 🌱 Replace deprecated marker for required fields Feb 2, 2026

camilamacedo86 changed the title ~~(Blocked by #2477) 🌱 Replace deprecated marker for required fields~~ 🌱 Replace deprecated marker for required fields Feb 2, 2026

Replace deprecated marker for required fields

d678562

camilamacedo86 force-pushed the fix-deprecation branch from 8f5cdde to d678562 Compare February 2, 2026 19:48

camilamacedo86 closed this Feb 2, 2026

camilamacedo86 reopened this Feb 2, 2026

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2026

camilamacedo86 added the api-diff-lint-override label Feb 3, 2026

openshift-ci bot assigned tmshort Feb 3, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2026

rashmigottipati approved these changes Feb 3, 2026

View reviewed changes

openshift-ci bot assigned rashmigottipati Feb 3, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2026

openshift-merge-bot bot merged commit 2582cf1 into operator-framework:main Feb 3, 2026
29 of 50 checks passed

camilamacedo86 deleted the fix-deprecation branch February 3, 2026 16:11

Conversation

camilamacedo86 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codecov bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

camilamacedo86 commented Jan 5, 2026

Uh oh!

camilamacedo86 commented Feb 2, 2026

Uh oh!

camilamacedo86 commented Feb 3, 2026

Uh oh!

openshift-ci bot commented Feb 3, 2026

Uh oh!

camilamacedo86 commented Feb 3, 2026

Uh oh!

openshift-ci bot commented Feb 3, 2026

Uh oh!

tmshort commented Feb 3, 2026

Uh oh!

rashmigottipati left a comment

Choose a reason for hiding this comment

Uh oh!

pedjak commented Feb 3, 2026

Uh oh!

openshift-ci bot commented Feb 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

camilamacedo86 commented Dec 23, 2025 •

edited

Loading

netlify bot commented Dec 23, 2025 •

edited

Loading

codecov bot commented Dec 23, 2025 •

edited

Loading