[FSSDK-11497] fire config update events synchronously#1043
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project's configuration update flow to fire events synchronously, ensuring the initial configuration is propagated immediately.
- Removed the asynchronous scheduleMicrotask wrapping for update events in the ProjectConfigManager.
- Updated tests to reflect the new synchronous behavior and adjust the timing of manager.start() calls accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/project_config/project_config_manager.ts | Removed scheduleMicrotask to emit update events synchronously. |
| lib/project_config/project_config_manager.spec.ts | Adjusted tests to register listeners before start() and reflect synchronous updates. |
Comments suppressed due to low confidence (1)
lib/project_config/project_config_manager.ts:167
- Switching to synchronous event emission may block the caller if listeners perform heavy work. Ensure that all update listeners are lightweight or document the synchronous behavior clearly.
scheduleMicrotask(() => {
junaed-optimizely
approved these changes
May 6, 2025
0410b2b to
903ca5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues