[FSSDK-11638] cleanups in event processing

[raju-opti]

Summary

• remove redundant functions
• small update in batch event processor eventStoreInCount maintenance logic

Issues

• FSSDK-11638

[Copilot]

Pull Request Overview

This PR refactors how user events are built by introducing a generic buildBaseEvent helper, removes legacy V1 log builders, updates tests to use the unified batch builder, and adds a caching check in the batch processor.

• Extracted common event fields into a new buildBaseEvent function and updated buildImpressionEvent/buildConversionEvent to use it
• Removed buildImpressionEventV1/buildConversionEventV1 from log_event.ts and revised specs to target makeEventBatch
• Added an early-return cache in BatchEventProcessor.readEventCountInStore to prevent redundant store reads

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
lib/event_processor/event_builder/user_event.ts	Refactored user events to use a generic BaseUserEvent<T> and buildBaseEvent helper
lib/event_processor/event_builder/log_event.ts	Deleted legacy V1 event builders
lib/event_processor/event_builder/log_event.spec.ts	Updated tests to call makeEventBatch and renamed suite
lib/event_processor/batch_event_processor.ts	Added a guard to skip store lookup when eventCountInStore is already set

Comments suppressed due to low confidence (3)

lib/event_processor/event_builder/user_event.ts:112

• [nitpick] Consider adding a JSDoc comment to buildBaseEvent to clarify its purpose and parameters for future maintainers.

const buildBaseEvent = <T extends  EventType>({

lib/event_processor/event_builder/user_event.ts:47

• [nitpick] If EventType is intended for reuse outside this module, consider exporting it (export type EventType) to improve discoverability.

type EventType = 'impression' | 'conversion';

lib/event_processor/event_builder/user_event.ts:146

• [nitpick] The new buildImpressionEvent and buildConversionEvent functions rely on buildBaseEvent; consider adding direct unit tests to cover their output structure.

}

[coveralls]

coverage: 79.797% (+0.009%) from 79.788%
when pulling 0e1e678 on raju/event_cleanup
into 41fed0d on master.

[junaed-optimizely]

LGTM!