doc: rewrite and restructure doc/P4sim/README.md#722
doc: rewrite and restructure doc/P4sim/README.md#722jafingerhut merged 2 commits intop4lang:masterfrom
Conversation
Signed-off-by: Mingyu Ma <mingyu.ma@tu-dresden.de>
Signed-off-by: mingyuma <mingyu.ma@tu-dresden.de>
|
Welcome to the project, @Mingyumaz! It looks like this is your first contribution. We noticed the DCO (Developer Certificate of Origin) check might fail if your commits aren't signed. To fix this, please ensure every commit has a For existing commits, you can fix them with: |
| * Portable Switch Architecture (PSA) | ||
| * Portable NIC Architecture (PNA) — not yet fully implemented |
There was a problem hiding this comment.
Could you please add links to the specs?
There was a problem hiding this comment.
Linking to this page for all P4.org specifications should be good, unless you want to link to a particular version of one of the spec documents: https://p4.org/specifications/
There was a problem hiding this comment.
I was thinking of linking to the latest version of each document, but your proposal is actually better.
|
I have tried out these instructions, they worked for me on an x86_64 Ubuntu 24.04 system as written without any problems, so I am approving and will merge these in. It would be nice to have links to the spec documents, but I am fine with those links being added with a later PR. |
Summary
This PR rewrites and restructures
doc/P4sim/README.mdto improve clarity, fix errors, and make it suitable for the p4lang official repository.Changes
P4SIM_DIRenvironment variable setup instructionsmailto:links for maintainer and contributor emails