Fix macOS test failure due to symlink path resolution in RandomDirectoryContext#69
Closed
Fix macOS test failure due to symlink path resolution in RandomDirectoryContext#69
Conversation
Co-authored-by: bittner <665072+bittner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add RandomDirectoryContext manager and API docs
Fix macOS test failure due to symlink path resolution in RandomDirectoryContext
Dec 13, 2025
557349a to
b613564
Compare
Member
|
Integrated manually in original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RandomDirectoryContexttest failed on macOS because/varis symlinked to/private/var.TemporaryDirectory.namereturns the symlink path whileos.getcwd()resolves to the real path, causing the assertion to fail.Changes
RandomDirectoryContext.__enter__(): Returnos.getcwd()instead ofself.nameto ensure consistent path resolution across platformsExample
Since we've already changed to the temporary directory,
os.getcwd()returns the resolved real path, eliminating platform-specific symlink inconsistencies.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.