Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 4, 2026

Pull Request

Summary by CodeRabbit

  • New Features

    • Support for asynchronously resolved server URLs so password reset and email verification flows work with dynamic configuration.
  • Tests

    • Added tests covering invalid password reset and verification link handling when the server URL is provided asynchronously.
  • Chores

    • Updated published package files path from public_html/ to public/.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 4, 2026

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Feb 4, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Converts PagesRouter.setConfig to async to allow on-demand config-key loading, updates route handlers to return the resulting promise, changes published package files entry from public_html/ to public/, and adds tests verifying async publicServerURL behavior for password reset and email verification flows.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Replaced published files entry public_html/ with public/.
PagesRouter Implementation
src/Routers/PagesRouter.js
Changed setConfig(req, failGracefully = false) to asynchronous (async) and updated callers to return/propagate the promise so config-key loading is awaited.
PagesRouter Tests
spec/PagesRouter.spec.js
Added test suite verifying async publicServerURL in password reset and email verification flows (two duplicated test blocks present).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and missing critical required sections. Add the Issue section with the issue reference, Approach section describing the changes, and Tasks section with relevant items checked or removed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: fixing default HTML pages for password reset and email verification endpoints.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.55%. Comparing base (8cc71cf) to head (68f7954).
⚠️ Report is 2 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha   #10034   +/-   ##
=======================================
  Coverage   92.54%   92.55%           
=======================================
  Files         190      190           
  Lines       15489    15490    +1     
  Branches      176      176           
=======================================
+ Hits        14334    14336    +2     
+ Misses       1143     1142    -1     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza merged commit e299107 into parse-community:alpha Feb 6, 2026
20 of 21 checks passed
parseplatformorg pushed a commit that referenced this pull request Feb 6, 2026
## [9.2.1-alpha.1](9.2.0...9.2.1-alpha.1) (2026-02-06)

### Bug Fixes

* Default HTML pages for password reset, email verification not found ([#10034](#10034)) ([e299107](e299107))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 9.2.1-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 6, 2026
@mtrezza mtrezza deleted the fix/default-pages-router branch February 6, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requestPasswordReset email link (“Verify Email” button) redirects to Not Found

2 participants