Skip to content

feat (icons): Icons API end points for retrieving icons. #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlabaj wants to merge 13 commits into
base: main
Choose a base branch
from
+1,104 −15
Open

feat (icons): Icons API end points for retrieving icons. #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3b20863
feat: Added icon api endpoints.
dlabaj Feb 4, 2026
a0d3855
feat: Added icons end points.
dlabaj Feb 4, 2026
da36b8d
chore: Updated with a few modifications.
dlabaj Feb 6, 2026
2437572
fixed broken test.
dlabaj Feb 6, 2026
bc103e1
chore: fix lint errors.
dlabaj Feb 6, 2026
e38d0a1
fix: Added prerender step for cloudflare.
dlabaj Feb 6, 2026
0d52a5a
fix: Updated to prerender svgs as well for cloud flare.
dlabaj Feb 6, 2026
a8654f0
Updated to react name as the end point.
dlabaj Feb 11, 2026
b380631
feat: Refactor icon utilities to use @patternfly/react-icons and upda…
dlabaj Feb 17, 2026
2b8c40c
updated to use prerelease to get static icons.
dlabaj Feb 17, 2026
160618a
Updates from review.
dlabaj Feb 17, 2026
1ebf628
Fixed issue with clouldflare and unable to retrieve the content from …
dlabaj Feb 17, 2026
fb500e3
Updated with review comments.
dlabaj Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ export default defineConfig({
vite: {
ssr: {
noExternal: ["@patternfly/*", "react-dropzone"],
external: ["node:fs", "node:path", "fs/promises", "path"]
external: ["fs", "node:fs", "node:path", "path", "fs/promises"]
},
server: {
fs: {
allow: ['./']
}
},
},
adapter: cloudflare()
adapter: cloudflare({
imageService: 'compile'
})
});
87 changes: 85 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@
"@nanostores/react": "^0.8.4",
"@patternfly/ast-helpers": "1.4.0-alpha.190",
"@patternfly/patternfly": "^6.0.0",
"@patternfly/quickstarts": "^6.0.0",
"@patternfly/react-code-editor": "^6.2.2",
"@patternfly/react-core": "^6.0.0",
"@patternfly/react-drag-drop": "^6.0.0",
"@patternfly/react-icons": "^6.0.0",
"@patternfly/react-icons": "6.5.0-prerelease.13",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

@patternfly/react-icons 6.5.0 stable release npm

💡 Result:

A stable @patternfly/react-icons@6.5.0 is not published on npm (no latest/stable tag pointing to 6.5.0).

The most recent stable (latest) version shown by public registries/CDN mirrors is 6.4.0 (published Oct 16, 2025). (classic.yarnpkg.com)

Citations:

Track @patternfly/react-icons prerelease pin for upgrade to stable.

6.5.0-prerelease.13 is an exact pin to a prerelease build. Prerelease packages carry no semver stability guarantees — APIs can change between iterations without a major bump — and this pin receives no automatic patch or security updates. While the commit notes this is intentional to access static icons, it introduces supply-chain fragility.

Once a stable 6.5.x (or higher) is published, this should be updated to a caret range (e.g., "^6.5.0"). Consider tracking this with a TODO comment or a follow-up issue.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 62, The package entry for `@patternfly/react-icons` is
currently pinned to the prerelease "6.5.0-prerelease.13"; change the dependency
version to a caret range (e.g., "^6.5.0") once a stable 6.5.x or higher is
published, and create a short follow-up issue or TODO in the repo to track this
upgrade; reference the dependency name "@patternfly/react-icons" and the current
prerelease pin "6.5.0-prerelease.13" when creating the issue so reviewers can
verify the replacement and future-proof the versioning.

"@patternfly/react-styles": "^6.0.0",
"@patternfly/react-table": "^6.0.0",
"@patternfly/react-tokens": "^6.0.0",
"@patternfly/quickstarts": "^6.0.0",
"@types/react": "^18.3.23",
"@types/react-dom": "^18.3.7",
"astro": "^5.15.9",
Expand All @@ -74,6 +74,7 @@
"react-docgen": "^7.1.1",
"react-dom": "^18.3.1",
"react-error-boundary": "^6.0.0",
"react-icons": "^5.5.0",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check where react-icons is imported in the repo (excluding node_modules)
rg -rn "from ['\"]react-icons" --glob '!**/node_modules/**' --glob '!package.json' -A 2

Repository: patternfly/patternfly-doc-core

Length of output: 56

🏁 Script executed:

#!/bin/bash
# Also check for require statements and any other references to react-icons
rg -rn "react-icons" --glob '!**/node_modules/**' --glob '!package-lock.json' --glob '!yarn.lock' | head -50

Repository: patternfly/patternfly-doc-core

Length of output: 2725

🏁 Script executed:

#!/bin/bash
# Check the actual package.json to see all dependencies and their context
cat -n package.json | grep -A 5 -B 5 "react-icons"

Repository: patternfly/patternfly-doc-core

Length of output: 1004

🏁 Script executed:

#!/bin/bash
# Search more broadly for any reference to react-icons, including comments, configs, etc.
rg -i "react-icons" --glob '!node_modules' --glob '!dist' --glob '!build' -t json -t js -t ts -t tsx -t jsx

Repository: patternfly/patternfly-doc-core

Length of output: 101

🏁 Script executed:

#!/bin/bash
# Check if it's perhaps a transitive dependency by looking for import statements in a different way
rg "import.*from.*react-icons|require.*react-icons" --glob '!node_modules'

Repository: patternfly/patternfly-doc-core

Length of output: 2646

🏁 Script executed:

#!/bin/bash
# List all source files to understand the codebase structure
git ls-files | grep -E "\.(ts|tsx|js|jsx)$" | head -20

Repository: patternfly/patternfly-doc-core

Length of output: 633

Remove unused react-icons dependency from package.json.

The codebase uses only @patternfly/react-icons for all icon imports. The standalone react-icons package (^5.5.0) at line 77 is not imported or referenced anywhere and should be removed.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 77, Remove the unused dependency "react-icons" from
package.json: open package.json, locate the dependency entry "react-icons":
"^5.5.0" and delete that line, then run your package manager (npm/yarn/pnpm) to
update lockfile and node_modules (e.g., npm install or yarn install) to ensure
the removal is applied; verify no imports reference react-icons and that
builds/tests still pass.

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to remove this import

"sass": "^1.90.0",
"typescript": "^5.9.2"
},
Expand All @@ -82,6 +83,8 @@
"@babel/preset-react": "^7.26.3",
"@babel/preset-typescript": "^7.26.0",
"@eslint/js": "^9.16.0",
"@patternfly/react-data-view": "^6.0.0",
"@patternfly/react-user-feedback": "^6.0.0",
"@semantic-release/git": "^10.0.1",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/react": "^16.1.0",
Expand Down Expand Up @@ -110,9 +113,7 @@
"ts-jest": "^29.2.5",
"ts-node": "^10.9.2",
"typescript-eslint": "^8.15.0",
"wrangler": "^4.20.0",
"@patternfly/react-user-feedback": "^6.0.0",
"@patternfly/react-data-view": "^6.0.0"
"wrangler": "^4.20.0"
},
"config": {
"commitizen": {
Expand Down
Loading