Open
Conversation
jhavl
added a commit
that referenced
this pull request
Apr 19, 2023
…ox-python # Conflicts: # roboticstoolbox/robot/ERobot.py
Owner
|
Hi @siilats thanks for your interest in the toolbox and apologies for the very late response. I'm happy to accept new robots to the toolbox, but this PR has got many aspects, and is quite large +50,000 lines which is a bit daunting. Could you pare this back a bit, keep the robot model, but don't include the notebooks, or save the notebooks after you've cleared the output. Is |
QuantuMope
added a commit
to HorizonRoboticsInternal/robotics-toolbox-python
that referenced
this pull request
Nov 12, 2024
Extracted from petercorke#342
QuantuMope
added a commit
to HorizonRoboticsInternal/robotics-toolbox-python
that referenced
this pull request
Nov 12, 2024
Extracted from petercorke#342
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please find it attached