Merged
Conversation
This helps noticing issues like phpGH-17204 and phpGH-17523 sooner.
petk
force-pushed
the
patch-re2c-enable-all-warnings
branch
from
649198b to
47c4c81
Compare
Member
Author
|
I think PHP 8.6 is ok branch for enabling this. Also recent systems already ship re2c 4 which will show a lot of warnings without this change anyway. So I think it's fine to prepare people to see more warnings in the build step sooner. Merging this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps noticing issues like GH-17204 and GH-17523 sooner.