Skip to content

Fix mistakenly allowed assignment to assignment through list operator #21123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iluuu1994 merged 1 commit into from
Feb 4, 2026
+21 −7
Merged

Fix mistakenly allowed assignment to assignment through list operator #21123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Zend/tests/oss-fuzz-480111866.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--TEST--
OSS-Fuzz #480111866: Assignment to assignment through list operator
--FILE--
<?php

[[&$y] = y] = y;

?>
--EXPECTF--
Fatal error: Assignments can only happen to writable values in %s on line %d
18 changes: 11 additions & 7 deletions Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2734,16 +2734,21 @@ void zend_emit_final_return(bool return_one) /* {{{ */
}
/* }}} */

static bool zend_propagate_list_refs(zend_ast *ast);

static inline bool zend_is_variable(const zend_ast *ast) /* {{{ */
{
if (ast->kind == ZEND_AST_VAR
return ast->kind == ZEND_AST_VAR
|| ast->kind == ZEND_AST_DIM
|| ast->kind == ZEND_AST_PROP
|| ast->kind == ZEND_AST_NULLSAFE_PROP
|| ast->kind == ZEND_AST_STATIC_PROP
|| ast->kind == ZEND_AST_ASSIGN_REF) {
|| ast->kind == ZEND_AST_STATIC_PROP;
}
/* }}} */

static bool zend_propagate_list_refs(zend_ast *ast);

static inline bool zend_is_passable_by_ref(const zend_ast *ast)
{
if (zend_is_variable(ast) || ast->kind == ZEND_AST_ASSIGN_REF) {
return true;
}
if (ast->kind == ZEND_AST_ASSIGN
Expand All @@ -2753,7 +2758,6 @@ static inline bool zend_is_variable(const zend_ast *ast) /* {{{ */
}
return false;
}
/* }}} */

static inline bool zend_is_call(const zend_ast *ast) /* {{{ */
{
Expand Down Expand Up @@ -3875,7 +3879,7 @@ static uint32_t zend_compile_args(
opcode = ZEND_SEND_VAR_NO_REF_EX;
}
}
} else if (zend_is_variable(arg) && !zend_ast_is_short_circuited(arg)) {
} else if (zend_is_passable_by_ref(arg) && !zend_ast_is_short_circuited(arg)) {
if (fbc && arg_num != (uint32_t) -1) {
if (ARG_SHOULD_BE_SENT_BY_REF(fbc, arg_num)) {
zend_compile_var(&arg_node, arg, BP_VAR_W, true);
Expand Down
Loading