Fix GH-20175: use 2048-bit default key size in OpenSSL test config#21212
Open
ThanhNguyxn wants to merge 1 commit intophp:PHP-8.3from
Open
Fix GH-20175: use 2048-bit default key size in OpenSSL test config#21212ThanhNguyxn wants to merge 1 commit intophp:PHP-8.3from
ThanhNguyxn wants to merge 1 commit intophp:PHP-8.3from
Conversation
OpenSSL 3.2+ defaults to security level 2, which rejects 1024-bit keys. Update the test helper config to use 2048-bit default key size so ext/openssl tests relying on generated config remain compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSSL 3.2+ defaults to security level 2, which rejects 1024-bit keys.
ext/openssl/tests/CertificateGenerator.incstill generated a per-test config withdefault_bits = 1024, causing failures in tests likegh10495.phptwhen defaultopenssl.cnfis not provided.This updates the generated test config to use
default_bits = 2048.Changes
ext/openssl/tests/CertificateGenerator.incdefault_bits = 1024->default_bits = 2048Related