Resource/Object specific data key support#296
Open
Spotnyk wants to merge 3 commits intophpclassic:masterfrom
Open
Resource/Object specific data key support#296Spotnyk wants to merge 3 commits intophpclassic:masterfrom
Spotnyk wants to merge 3 commits intophpclassic:masterfrom
Conversation
Contributor
Author
|
As a "quick glance" example of what this fixes: Currently (at every implementation point): $shopify->AssignedFulfillmentOrders->get(['assignment_status' => 'in_progress'], null, 'fulfillment_orders');WIth change: protected $dataKey = 'fulfillment_orders';Runtime: $shopify->AssignedFulfillmentOrders->get(['assignment_status' => 'in_progress']); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to support resource/object level data keys as well as request level.
As example:
The recently added
AssignedFulfillmentOrderresource. It returns results with thefulfillment_orderskey, which does not match the resource key.While a data key can be manually passed to
get(), it feels messy for a resource which always requires a custom data key.Setting the protected
$dataKeyproperty in a resource object will cause the specified key to be used with results (unless a key is provided manually).(Therefore, this PR "fixes" the response payload from
AssignedFulfillmentOrder)