Skip to content

mb_str_pad is an impure function #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into from
Feb 2, 2026
+12 −8
Merged

mb_str_pad is an impure function #4849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/functionMetadata_original.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@
'lchgrp' => ['hasSideEffects' => true],
'lchown' => ['hasSideEffects' => true],
'link' => ['hasSideEffects' => true],
'mb_str_pad' => ['hasSideEffects' => false],
'mkdir' => ['hasSideEffects' => true],
'move_uploaded_file' => ['hasSideEffects' => true],
'ob_clean' => ['hasSideEffects' => true],
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"hoa/compiler": "3.17.08.08",
"hoa/exception": "^1.0",
"hoa/file": "1.17.07.11",
"jetbrains/phpstorm-stubs": "dev-master#fb50cfe627488530a79377f3694764eb6ce78471",
"jetbrains/phpstorm-stubs": "dev-master#5fd9e4ef2b4c2a00848ea62d78bf3aa81f43e038",
"nette/bootstrap": "^3.0",
"nette/di": "^3.1.4",
"nette/neon": "3.3.4",
Expand Down
10 changes: 5 additions & 5 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion resources/functionMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,13 +1496,16 @@
'mb_eregi_replace' => ['hasSideEffects' => false],
'mb_get_info' => ['hasSideEffects' => false],
'mb_http_input' => ['hasSideEffects' => false],
'mb_lcfirst' => ['hasSideEffects' => false],
'mb_list_encodings' => ['hasSideEffects' => false],
'mb_ltrim' => ['hasSideEffects' => false],
'mb_ord' => ['hasSideEffects' => false],
'mb_output_handler' => ['hasSideEffects' => false],
'mb_preferred_mime_name' => ['hasSideEffects' => false],
'mb_rtrim' => ['hasSideEffects' => false],
'mb_scrub' => ['hasSideEffects' => false],
'mb_split' => ['hasSideEffects' => false],
'mb_str_pad' => ['hasSideEffects' => false],
'mb_str_pad' => ['hasSideEffects' => true],
Copy link
Member

@ondrejmirtes ondrejmirtes Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What side effect does this function have?

Copy link
Contributor Author

@longwave longwave Feb 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 mb_str_pad(
    string $string,
    int $length,
    string $pad_string = " ",
    int $pad_type = STR_PAD_RIGHT,
    ?string $encoding = null
): string

If $encoding is null then the internal encoding is used, which can be changed by mb_internal_encoding(). This is not a side effect but means it's not entirely a pure function?

Copy link
Member

@ondrejmirtes ondrejmirtes Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, good enough :) Thank you.

'mb_str_split' => ['hasSideEffects' => false],
'mb_strcut' => ['hasSideEffects' => false],
'mb_strimwidth' => ['hasSideEffects' => false],
Expand All @@ -1520,6 +1523,8 @@
'mb_strwidth' => ['hasSideEffects' => false],
'mb_substr' => ['hasSideEffects' => false],
'mb_substr_count' => ['hasSideEffects' => false],
'mb_trim' => ['hasSideEffects' => false],
'mb_ucfirst' => ['hasSideEffects' => false],
'mbereg_search_setpos' => ['hasSideEffects' => false],
'md5' => ['hasSideEffects' => false],
'md5_file' => ['hasSideEffects' => true],
Expand Down
Loading