Merged
Conversation
Go 1.26 tightened fmt format verb checking. `printer.Format` is a `type Format int`, and `%q` on an int-based type formats as a rune literal rather than a quoted string. This was flagged by the stricter vet checks. Fix by changing `Format.String()` to a value receiver (so it works on values returned by `Printer.Format()`) and replacing `%q` with `"%s"` across all call sites to properly invoke the Stringer interface.
mattrobenolt
approved these changes
Feb 24, 2026
no-itsbackpack
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Go version from 1.25 to 1.26 and fixes lint failures caused by stricter
fmtformat verb checking in the new version.Changes
go.modfrom Go 1.25.5 to 1.26.0Format.String()from a pointer receiver to a value receiver so it can be called onFormatvalues directly%qwith"%s"in allfmt.Errorfcalls that format aprinter.Formatvalue —%qon an int-based type formats as a rune literal (not a quoted string), which Go 1.26's vet now correctly flags