This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Automated movies and TV series search#324
Open
harsh7x18 wants to merge 1 commit intopowerexploit:masterfrom
harsh7x18:imdb
Open
Automated movies and TV series search#324harsh7x18 wants to merge 1 commit intopowerexploit:masterfrom harsh7x18:imdb
harsh7x18 wants to merge 1 commit intopowerexploit:masterfrom
harsh7x18:imdb
Conversation
HighnessAtharva
suggested changes
May 3, 2021
HighnessAtharva
left a comment
HighnessAtharva
left a comment
There was a problem hiding this comment.
Great work. Implementing the suggested changes will enhance the readability. Please do so if possible.
|
|
||
| #READ THE DOCUMENTATION FIRST, THEN MOVE ON TO THE SOURCE CODE AS DOCUMENTATION WILL BRIEF YOU ABOUT THE PYTHON MODULE, DATA STRUCTURES USED AND ALSO HOW TO WORK THROUGH THIS PROGRAM. | ||
|
|
||
| """For running this code you have to download IMDbPy package from google. IMDbPY is a Python package useful to retrieve and manage the data of the IMDb movie database about movies, people, |
There was a problem hiding this comment.
Docstrings should ideally be like this:-
"""
Your text here.
"""
| characters and companies.Platform-independent and written in Python 3 it can retrieve data from both the IMDb’s web server and a local copy of the whole database. | ||
| IMDbPY package can be very easily used by programmers and developers to provide access to the IMDb’s data to their programs.""" | ||
|
|
||
| #For understanding this project you need to have a basic knowledge about python, definition of database, module, instances and lists. |
|
|
||
| #For understanding this project you need to have a basic knowledge about python, definition of database, module, instances and lists. | ||
|
|
||
| """While running the code it asks for a movie or tv series name. After you enter the movie or a tv series name it returns a list of movies or tv series with its id which are related to the |
| try : | ||
| for director in movies["directors"] : # try and except is used to prevent error messages that show up while compiling | ||
| print(director["name"]) | ||
| except : |
There was a problem hiding this comment.
Can you please recheck if printing the name of the writers goes within the except block and not the try block?
| @@ -0,0 +1,67 @@ | |||
| #IT IS A MINI-IMDB PROJECT THAT PROVIDES INFORMATION ABOUT ANY MOVIE OR TV SERIES WHEN SEARCHED. | |||
There was a problem hiding this comment.
Nicely coded project. Please try and get the code formatting to PEP8 format for improved readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IT IS A MINI-IMDB PROJECT THAT PROVIDES INFORMATION ABOUT ANY MOVIE OR TV SERIES WHEN SEARCHED.
This project is coded in python language and uses basics of python data structure - lists, OOPS and some basics of database.
Do remember to read the documentation at the top of the source code for smooth learning.