-
Notifications
You must be signed in to change notification settings - Fork 1
Fix auto-install of pnpm and node on mode init #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
That IS lovely! Interesting, I will check how I can distinguist command output and general shell output. (Ah yes, I remember now, I am using a full-on interactive shell so we can have all the env variables, but that of course also triggers any user-defined shell startup code in |
|
@stephanmax this is working for me on gentoo/zsh/wayland /cc @lee2sman |
|
how can i test? do i need to build from source? i don't have a kotlin or java environment set up for example. |
|
let us know what you're thinking for handling running shell commands @stephanmax @lee2sman ooops nevermind. ill let you know when this is merged. i forgot you're not building |
This ignores any user-defined output in an interactive shell that might precede the output of the command.
|
I think the easiest workaround is only considering the last line of the command output. This is not as rigorous a solution as I’d like, but my other ideas fall short as well.
|



Changes
probeCommandto check for presence of critical toolspnpmandnodebuilderoptionalFixes #14