Skip to content

nvme: add namespace parameters#3360

Open
ShashwatHiregoudar wants to merge 18 commits intoprometheus:masterfrom
ShashwatHiregoudar:master
Open

nvme: add namespace parameters#3360
ShashwatHiregoudar wants to merge 18 commits intoprometheus:masterfrom
ShashwatHiregoudar:master

Conversation

@ShashwatHiregoudar
Copy link

@ShashwatHiregoudar ShashwatHiregoudar commented Jul 9, 2025

Improvement of the NVMe collector in node-exporter, to include the below-mentioned NVMe namespace-specific parameters NUSE
NCAP
NSZE
LBA Size
ANA State

@ShashwatHiregoudar
adding nvme namespace parameters
53848dd 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
linting the code
e252d97 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar ShashwatHiregoudar mentioned this pull request Jul 10, 2025
Closed
@ShashwatHiregoudar
Copy link
Author

ShashwatHiregoudar commented Jul 10, 2025

cc:
@SuperQ
@discordianfish

@discordianfish
Copy link
Member

discordianfish commented Sep 17, 2025

Could you try to add tests for the new metrics?

@ShashwatHiregoudar
adding the namespace tests too
be1ad00 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
correcting the formatting
1213dcc 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
correcting the order too
d99435f 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
Merge branch 'master' into master
4edb9d9
@ShashwatHiregoudar
Copy link
Author

ShashwatHiregoudar commented Oct 3, 2025

I have updated the fixtures and the output.txt.
@discordianfish @SuperQ
Please suggest additional edits if needed.

@discordianfish
Copy link
Member

discordianfish commented Nov 12, 2025

Seems reasonable but parsing should go into the prometheus/procfs module

@ShashwatHiregoudar
Copy link
Author

ShashwatHiregoudar commented Nov 20, 2025

Ok 👍

prometheus/procfs#765
This PR should do it.

please approve it

@ShashwatHiregoudar
Copy link
Author

ShashwatHiregoudar commented Nov 20, 2025 •
edited
Loading

After they are merged, i can apply this patch and update the go.mod file with the new release tag
procfs.patch

@ShashwatHiregoudar ShashwatHiregoudar mentioned this pull request Jan 7, 2026
Merged
@ShashwatHiregoudar
Copy link
Author

ShashwatHiregoudar commented Jan 13, 2026

hi @discordianfish
can you please ask Ben Kochie to approve the above mentioned procfs-PR.

It's been a while.

@discordianfish discordianfish requested a review from SuperQ January 16, 2026 10:37
discordianfish
discordianfish requested changes Jan 16, 2026
View reviewed changes
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry - right still needs prometheus/procfs#765 first

Shashwat Hiregoudar and others added 2 commits February 28, 2026 23:03
refactor: uprated procfs
98d6cf7 
refactor: use updated  library to collect NVMe namespace metrics directly from structured data instead of manual sysfs parsing.
Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
@ShashwatHiregoudar
go mod tidy
d07acf9 
go mod tidy

Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
Copy link
Author

ShashwatHiregoudar commented Feb 28, 2026

@SuperQ can you please create a new release in procfs,
I am currently using the go mod by the commit id, but the correct way would be by release.

@SuperQ
Copy link
Member

SuperQ commented Feb 28, 2026

I cut a new procfs version a few hours ago.

@ShashwatHiregoudar
Update github.com/prometheus/procfs version
ea12a36 
Updated the version of github.com/prometheus/procfs to v0.20.1.

Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
Update procfs dependency version in go.sum
4720bcc 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
Update Go version from 1.25.0 to 1.26
2a166b3 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
SuperQ
SuperQ requested changes Mar 2, 2026
View reviewed changes
ShashwatHiregoudar and others added 2 commits March 2, 2026 14:09
@ShashwatHiregoudar
fix: update NVMe namespace size to reflect accurate byte count
e708430
@ShashwatHiregoudar @SuperQ
Apply suggestion from @SuperQ
cfd51ce 
Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar ShashwatHiregoudar force-pushed the master branch 2 times, most recently from ae708b5 to cfd51ce Compare March 3, 2026 08:04
@ShashwatHiregoudar
empty commit for DCO check
d2852bd 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
@ShashwatHiregoudar
empty commit for DCO check
1d43eab 
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperQ SuperQ SuperQ requested changes

@discordianfish discordianfish Awaiting requested review from discordianfish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShashwatHiregoudar @discordianfish @SuperQ